diff mbox

[02/16] ASoC: cs42l73: Remove redundant OOM message

Message ID 1403258352-8210-2-git-send-email-sachin.kamat@samsung.com (mailing list archive)
State Accepted
Commit 10d95ad48b4bf49b9853466654654eec2d9df031
Headers show

Commit Message

Sachin Kamat June 20, 2014, 9:58 a.m. UTC 
Let memory subsystem handle the error logging.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
 sound/soc/codecs/cs42l73.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Paul Handrigan June 20, 2014, 2:48 p.m. UTC | #1 
> On Jun 20, 2014, at 5:04 AM, "Sachin Kamat" <sachin.kamat@samsung.com> wrote:
> 
> Let memory subsystem handle the error logging.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> sound/soc/codecs/cs42l73.c |    4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
> index ae3717992d56..e3b601624794 100644
> --- a/sound/soc/codecs/cs42l73.c
> +++ b/sound/soc/codecs/cs42l73.c
> @@ -1408,10 +1408,8 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client,
> 
>    cs42l73 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l73_private),
>                   GFP_KERNEL);
> -    if (!cs42l73) {
> -        dev_err(&i2c_client->dev, "could not allocate codec\n");
> +    if (!cs42l73)
>        return -ENOMEM;
> -    }
> 
>    cs42l73->regmap = devm_regmap_init_i2c(i2c_client, &cs42l73_regmap);
>    if (IS_ERR(cs42l73->regmap)) {
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-

Please CC the driver maintainers.

Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Mark Brown June 27, 2014, 11:48 a.m. UTC | #2 
On Fri, Jun 20, 2014 at 03:28:58PM +0530, Sachin Kamat wrote:
> Let memory subsystem handle the error logging.

Applied all, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index ae3717992d56..e3b601624794 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1408,10 +1408,8 @@  static int cs42l73_i2c_probe(struct i2c_client *i2c_client,
 
 	cs42l73 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l73_private),
 			       GFP_KERNEL);
-	if (!cs42l73) {
-		dev_err(&i2c_client->dev, "could not allocate codec\n");
+	if (!cs42l73)
 		return -ENOMEM;
-	}
 
 	cs42l73->regmap = devm_regmap_init_i2c(i2c_client, &cs42l73_regmap);
 	if (IS_ERR(cs42l73->regmap)) {