From patchwork Fri Jun 20 09:59:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 4387711 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0DA80BEEAA for ; Fri, 20 Jun 2014 10:05:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 466752037F for ; Fri, 20 Jun 2014 10:05:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id DEF44203AF for ; Fri, 20 Jun 2014 10:05:34 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5614D2650BC; Fri, 20 Jun 2014 12:05:31 +0200 (CEST) Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id A96FD261ADB; Fri, 20 Jun 2014 12:03:14 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E6C1C2650C0; Fri, 20 Jun 2014 12:03:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, NO_DNS_FOR_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by alsa0.perex.cz (Postfix) with ESMTP id 7BD31261ABF for ; Fri, 20 Jun 2014 12:02:36 +0200 (CEST) Received: by mail-pa0-f50.google.com with SMTP id bj1so2975048pad.9 for ; Fri, 20 Jun 2014 03:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=mv1RIUG5Q7P2M35x9JmsnzjGQlQ0bMetRDs/m4Ry6Sg=; b=Date2XUrLN0Uuv8JdmbBbYOZLjEvZcRiIlr+eyjj1edLtGeDIql/xkdoEuZ2ZnIN1O qCc87l4ckHfWfGz9okAnntKmGwmCpi3WotpsPL0ew57Uo1DocMwGif56gSBlyNbyM+Hg 63HKMyZu3Sh4ifnACyo7TsuPaxg0gwsZGum+jXEoP+4uYcH8uU8EJed/Lw5+ZkAX+brW U4BQzXZgEVGXdcipXG0FhugaZKReixO1+eZjsVzfMp4zns6b+tG7IWBO087cGQCLD6oa F2NU7yX1PYwNFrNdP4d8cVKRYMX9nGBq0gwbRZBwXDOFN9R21+rchuQjeYWrwuIy3jxZ zV0A== X-Received: by 10.66.164.234 with SMTP id yt10mr2848885pab.65.1403258555632; Fri, 20 Jun 2014 03:02:35 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id ha10sm12718305pbd.1.2014.06.20.03.02.32 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Jun 2014 03:02:34 -0700 (PDT) From: Sachin Kamat To: alsa-devel@alsa-project.org Date: Fri, 20 Jun 2014 15:29:01 +0530 Message-Id: <1403258352-8210-5-git-send-email-sachin.kamat@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1403258352-8210-1-git-send-email-sachin.kamat@samsung.com> References: <1403258352-8210-1-git-send-email-sachin.kamat@samsung.com> Cc: broonie@kernel.org, spk.linux@gmail.com, lgirdwood@gmail.com Subject: [alsa-devel] [PATCH 05/16] ASoC: tlv320aic3x: Remove redundant OOM message X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Let memory subsystem handle the error logging. Signed-off-by: Sachin Kamat --- sound/soc/codecs/tlv320aic3x.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c index e12fafbb1e09..446303198ffd 100644 --- a/sound/soc/codecs/tlv320aic3x.c +++ b/sound/soc/codecs/tlv320aic3x.c @@ -1477,10 +1477,8 @@ static int aic3x_i2c_probe(struct i2c_client *i2c, u32 value; aic3x = devm_kzalloc(&i2c->dev, sizeof(struct aic3x_priv), GFP_KERNEL); - if (aic3x == NULL) { - dev_err(&i2c->dev, "failed to create private data\n"); + if (!aic3x) return -ENOMEM; - } aic3x->regmap = devm_regmap_init_i2c(i2c, &aic3x_regmap); if (IS_ERR(aic3x->regmap)) { @@ -1498,10 +1496,8 @@ static int aic3x_i2c_probe(struct i2c_client *i2c, } else if (np) { ai3x_setup = devm_kzalloc(&i2c->dev, sizeof(*ai3x_setup), GFP_KERNEL); - if (ai3x_setup == NULL) { - dev_err(&i2c->dev, "failed to create private data\n"); + if (!ai3x_setup) return -ENOMEM; - } ret = of_get_named_gpio(np, "gpio-reset", 0); if (ret >= 0)