| Message ID | 1404629414-3263-1-git-send-email-badarkhe.manish@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/06/2014 09:50 AM, Manish Badarkhe wrote: > Replaced snd_soc_register_component with its devres equivalent, > devm_snd_soc_register_component. > > Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> > --- > :100644 100644 6925d71... 011e30e... M sound/soc/omap/omap-dmic.c > sound/soc/omap/omap-dmic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c > index 6925d71..011e30e 100644 > --- a/sound/soc/omap/omap-dmic.c > +++ b/sound/soc/omap/omap-dmic.c > @@ -490,7 +490,7 @@ static int asoc_dmic_probe(struct platform_device *pdev) > } > > > - ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component, > + ret = devm_snd_soc_register_component(&pdev->dev, &omap_dmic_component, > &omap_dmic_dai, 1); Would you align the parameters at the same time? > if (ret) > goto err_put_clk; > @@ -510,7 +510,6 @@ static int asoc_dmic_remove(struct platform_device *pdev) > { > struct omap_dmic *dmic = platform_get_drvdata(pdev); > > - snd_soc_unregister_component(&pdev->dev); > clk_put(dmic->fclk); > > return 0; >
Hi Peter, On Mon, Jul 7, 2014 at 3:00 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > On 07/06/2014 09:50 AM, Manish Badarkhe wrote: >> Replaced snd_soc_register_component with its devres equivalent, >> devm_snd_soc_register_component. >> >> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> >> --- >> :100644 100644 6925d71... 011e30e... M sound/soc/omap/omap-dmic.c >> sound/soc/omap/omap-dmic.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c >> index 6925d71..011e30e 100644 >> --- a/sound/soc/omap/omap-dmic.c >> +++ b/sound/soc/omap/omap-dmic.c >> @@ -490,7 +490,7 @@ static int asoc_dmic_probe(struct platform_device *pdev) >> } >> >> >> - ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component, >> + ret = devm_snd_soc_register_component(&pdev->dev, &omap_dmic_component, >> &omap_dmic_dai, 1); > > Would you align the parameters at the same time? Sure, will do it and send next version. Regards Manish Badarkhe
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c index 6925d71..011e30e 100644 --- a/sound/soc/omap/omap-dmic.c +++ b/sound/soc/omap/omap-dmic.c @@ -490,7 +490,7 @@ static int asoc_dmic_probe(struct platform_device *pdev) } - ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component, + ret = devm_snd_soc_register_component(&pdev->dev, &omap_dmic_component, &omap_dmic_dai, 1); if (ret) goto err_put_clk; @@ -510,7 +510,6 @@ static int asoc_dmic_remove(struct platform_device *pdev) { struct omap_dmic *dmic = platform_get_drvdata(pdev); - snd_soc_unregister_component(&pdev->dev); clk_put(dmic->fclk); return 0;
Replaced snd_soc_register_component with its devres equivalent, devm_snd_soc_register_component. Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> --- :100644 100644 6925d71... 011e30e... M sound/soc/omap/omap-dmic.c sound/soc/omap/omap-dmic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)