diff mbox

[V2] ASoC: omap-dmic: Use devm_snd_soc_register_component

Message ID 1404838397-5309-1-git-send-email-badarkhe.manish@gmail.com (mailing list archive)
State Accepted
Commit 159baadf59416d9ddf860bac9f39e19a04b21603
Headers show

Commit Message

Manish Badarkhe July 8, 2014, 4:53 p.m. UTC 
Replaced snd_soc_register_component with its devres equivalent,
devm_snd_soc_register_component.

Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
---
Changes since V1:
        Aligned function parameter properly.

:100644 100644 6925d71... f125eb9... M	sound/soc/omap/omap-dmic.c
 sound/soc/omap/omap-dmic.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Peter Ujfalusi July 9, 2014, 5:46 a.m. UTC | #1 
On 07/08/2014 07:53 PM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
> 
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
> Changes since V1:
>         Aligned function parameter properly.
> 
> :100644 100644 6925d71... f125eb9... M	sound/soc/omap/omap-dmic.c
>  sound/soc/omap/omap-dmic.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
> index 6925d71..f125eb9 100644
> --- a/sound/soc/omap/omap-dmic.c
> +++ b/sound/soc/omap/omap-dmic.c
> @@ -490,8 +490,9 @@ static int asoc_dmic_probe(struct platform_device *pdev)
>  	}
>  
>  
> -	ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component,
> -					 &omap_dmic_dai, 1);
> +	ret = devm_snd_soc_register_component(&pdev->dev,
> +					      &omap_dmic_component,
> +					      &omap_dmic_dai, 1);
>  	if (ret)
>  		goto err_put_clk;
>  
> @@ -510,7 +511,6 @@ static int asoc_dmic_remove(struct platform_device *pdev)
>  {
>  	struct omap_dmic *dmic = platform_get_drvdata(pdev);
>  
> -	snd_soc_unregister_component(&pdev->dev);
>  	clk_put(dmic->fclk);
>  
>  	return 0;
>
Mark Brown July 9, 2014, 8:16 a.m. UTC | #2 
On Tue, Jul 08, 2014 at 10:23:17PM +0530, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index 6925d71..f125eb9 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -490,8 +490,9 @@  static int asoc_dmic_probe(struct platform_device *pdev)
 	}
 
 
-	ret = snd_soc_register_component(&pdev->dev, &omap_dmic_component,
-					 &omap_dmic_dai, 1);
+	ret = devm_snd_soc_register_component(&pdev->dev,
+					      &omap_dmic_component,
+					      &omap_dmic_dai, 1);
 	if (ret)
 		goto err_put_clk;
 
@@ -510,7 +511,6 @@  static int asoc_dmic_remove(struct platform_device *pdev)
 {
 	struct omap_dmic *dmic = platform_get_drvdata(pdev);
 
-	snd_soc_unregister_component(&pdev->dev);
 	clk_put(dmic->fclk);
 
 	return 0;