diff mbox

[-next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe()

Message ID 1406553660-30014-1-git-send-email-weiyj_lk@163.com (mailing list archive)
State Accepted
Commit 55b219440b255f9b9064c621550d29e5f4f8c20f
Headers show

Commit Message

weiyj_lk@163.com July 28, 2014, 1:21 p.m. UTC 
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 sound/soc/rockchip/rockchip_i2s.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Mark Brown July 28, 2014, 1:46 p.m. UTC | #1 
On Mon, Jul 28, 2014 at 09:21:00PM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb..52ccced 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -427,10 +427,8 @@  static int rockchip_i2s_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	regs = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(regs)) {
-		dev_err(&pdev->dev, "No memory resource\n");
+	if (IS_ERR(regs))
 		return PTR_ERR(regs);
-	}
 
 	i2s->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
 					    &rockchip_i2s_regmap_config);