From patchwork Mon Jul 28 13:21:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 4634491 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 68B6FC0338 for ; Mon, 28 Jul 2014 13:21:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9DDD82012D for ; Mon, 28 Jul 2014 13:21:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 6D99720149 for ; Mon, 28 Jul 2014 13:21:28 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id C5CB5265112; Mon, 28 Jul 2014 15:21:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, NO_DNS_FOR_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id BDC292619FE; Mon, 28 Jul 2014 15:21:15 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 26B53261B1B; Mon, 28 Jul 2014 15:21:14 +0200 (CEST) Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by alsa0.perex.cz (Postfix) with ESMTP id 2E1D6261740 for ; Mon, 28 Jul 2014 15:21:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=xHn5b3PvDfsBg7Dax6 QjSBFwuyrAlngBFRD59giNph8=; b=bBquwtp9GH2EQS3m6kMA4pW8v0pGXycGQE cVt2ViXeB/uHWvrUSDIDjqsV/r/6C1Ma68vlBp9Uw1ADEKPrftzXbfp0cWBsciTu ydMsskxLY64epgEh5s9GTy+ISZTuQ3UEuffw4wtLJgy+s7rohoyW6w6IbtxwNNWN My2+ch1oE= Received: from localhost.localdomain.localdomain (unknown [121.225.181.73]) by smtp8 (Coremail) with SMTP id DMCowEDpHk89TtZT1BiJAw--.1104S2; Mon, 28 Jul 2014 21:21:01 +0800 (CST) X-Coremail-DSSMTP: 121.225.181.73 From: weiyj_lk@163.com To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Grant Likely , Rob Herring , Jianqun Xu Date: Mon, 28 Jul 2014 21:21:00 +0800 Message-Id: <1406553660-30014-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 1.9.3 X-CM-TRANSID: DMCowEDpHk89TtZT1BiJAw--.1104S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kCw4kuF47tr4DGr45Jrb_yoWDGrX_t3 yUurs3XFy0vry3ta4DAa43CrsxXan2kry8WF4jyFy7JFyDZr4rKF48Ary7Wry5W39akr1x Wr1jqr4UCFyfAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYOeOJUUUUU== X-Originating-IP: [121.225.181.73] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiNQfW1lHZXm4hyQAAsi Cc: Wei Yongjun , alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH -next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- sound/soc/rockchip/rockchip_i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index af1d8eb..52ccced 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -427,10 +427,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(regs)) { - dev_err(&pdev->dev, "No memory resource\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } i2s->regmap = devm_regmap_init_mmio(&pdev->dev, regs, &rockchip_i2s_regmap_config);