From patchwork Mon Sep 1 00:47:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 4815621 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 336E9C0338 for ; Mon, 1 Sep 2014 00:48:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DF3720107 for ; Mon, 1 Sep 2014 00:48:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 3E7C320120 for ; Mon, 1 Sep 2014 00:48:19 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id CD9242625DB; Mon, 1 Sep 2014 02:48:17 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id B0EE1261B28; Mon, 1 Sep 2014 02:48:06 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4F521261B2A; Mon, 1 Sep 2014 02:48:05 +0200 (CEST) Received: from m12-18.163.com (m12-18.163.com [220.181.12.18]) by alsa0.perex.cz (Postfix) with ESMTP id 511F2261B25 for ; Mon, 1 Sep 2014 02:47:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=erlU7vjIPUGRYjsaeo BOUdP8BcZjEGurTmZwP12UBkI=; b=hnwmN4Q7g7mZakTp7vhOC9P2bc1gXLTKf6 En4U2XeAeZYO2uW9hY6JuzmaIzjrRFPSNb6sNU1492VQKwJAx1+GQwkhwylAAgXZ Mjy46u6ZcMODDunQhlxZA3RU3r3Vs7ApGKQUZ/zHIjYfqx/M1uiZkF0QoerG2c6H 0f8ShYaOI= Received: from localhost.localdomain.localdomain (unknown [117.88.144.180]) by smtp14 (Coremail) with SMTP id EsCowEC5MlI4wgNU1xFBBQ--.1245S2; Mon, 01 Sep 2014 08:47:54 +0800 (CST) X-Coremail-DSSMTP: 117.88.144.180 From: weiyj_lk@163.com To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Sean Cross Date: Mon, 1 Sep 2014 08:47:50 +0800 Message-Id: <1409532470-32364-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 1.9.3 X-CM-TRANSID: EsCowEC5MlI4wgNU1xFBBQ--.1245S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7WryUGw4xuw1kCFW5ZFy7Wrg_yoW3Xwc_G3 yUW3yqvrWj9FZrtrWjgFWay393XF15uFWF9rnIy3W7tryDtwn8C34jqw13uF4IqF4v9FyY qF1Sqr4xZF1xJjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnDxhJUUUUU== X-Originating-IP: [117.88.144.180] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbioxr51lD+WG5XnQAAsE Cc: Wei Yongjun , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- sound/soc/codecs/es8328.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 7a9f65a..3ff7870 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -665,6 +665,7 @@ static int es8328_codec_probe(struct snd_soc_codec *codec) es8328->clk = devm_clk_get(codec->dev, NULL); if (IS_ERR(es8328->clk)) { dev_err(codec->dev, "codec clock missing or invalid\n"); + ret = PTR_ERR(es8328->clk); goto clk_fail; }