| Message ID | 1415606519-30744-2-git-send-email-krishna.md@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 10, 2014 at 01:31:56PM +0530, Krishna Mohan Dani wrote: > Document the device tree binding for the ALC5631 codec and update vendor > specific prefix for the Realtek. This driver isn't in mainline, you need to submit the driver.
Hi Mark Brown,
The codec driver is present in mainline as rt5631.c., Its realtek's
alc5631 so retained that name.
Similarly machine driver also is named as arndale_rt5631.c but inside that
driver I have used alc5631 naming as the
audio daughter card on arndale board mentions alc5631 so I have used this
convention here so that user should not
feel the absence of the driver.
Is that ok or do you want to have one naming all over?
-Krishna
--------------------------------------------------
From: "Mark Brown" <broonie@kernel.org>
Sent: Monday, November 10, 2014 7:07 PM
To: "Krishna Mohan Dani" <krishna.md@samsung.com>
Cc: <linux-samsung-soc@vger.kernel.org>;
<linux-arm-kernel@lists.infradead.org>; <alsa-devel@alsa-project.org>;
<kgene.kim@samsung.com>
Subject: Re: [PATCH 1/4] ASoC: ALC5631: Add device tree binding
documentation
On Mon, Nov 10, 2014 at 01:31:56PM +0530, Krishna Mohan Dani wrote:
> Document the device tree binding for the ALC5631 codec and update vendor
> specific prefix for the Realtek.
This driver isn't in mainline, you need to submit the driver.
On Mon, Nov 10, 2014 at 07:39:51PM +0530, D Krishna Mohan wrote: > Hi Mark Brown, Don't top post. > The codec driver is present in mainline as rt5631.c., Its realtek's > alc5631 so retained that name. > Similarly machine driver also is named as arndale_rt5631.c but inside that > driver I have used alc5631 naming as the > audio daughter card on arndale board mentions alc5631 so I have used this > convention here so that user should not > feel the absence of the driver. > Is that ok or do you want to have one naming all over? Ugh, OK. That was hidden at the back end of the series. Please: - Use subject lines matching the style for the subsystem. - Support both variants of the device name, not just one. - of_match_table() is there to reduce ifdefs.
diff --git a/Documentation/devicetree/bindings/sound/rt5631.txt b/Documentation/devicetree/bindings/sound/rt5631.txt new file mode 100644 index 0000000..9e68c4d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rt5631.txt @@ -0,0 +1,41 @@ +ALC5631 audio CODEC + +This device supports I2C only. + +Required properties: + + - compatible : "realtek,alc5631" + + - reg : the I2C address of the device. + +Pins on the device (for linking into audio routes): + + * SPK_OUT_R_P + * SPK_OUT_R_N + * SPK_OUT_L_P + * SPK_OUT_L_N + * HP_OUT_L + * HP_OUT_R + * AUX_OUT2_LP + * AUX_OUT2_RN + * AUX_OUT1_LP + * AUX_OUT1_RN + * AUX_IN_L_JD + * AUX_IN_R_JD + * MONO_IN_P + * MONO_IN_N + * MIC1_P + * MIC1_N + * MIC2_P + * MIC2_N + * MONO_OUT_P + * MONO_OUT_N + * MICBIAS1 + * MICBIAS2 + +Example: + +alc5631: alc5631@1e { + compatible = "realtek,alc5631"; + reg = <0x1a>; +};
Document the device tree binding for the ALC5631 codec and update vendor specific prefix for the Realtek. Signed-off-by: Krishna Mohan Dani <krishna.md@samsung.com> --- Documentation/devicetree/bindings/sound/rt5631.txt | 41 ++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt