From patchwork Thu Nov 13 15:14:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 5298751 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EEFC4C11AC for ; Thu, 13 Nov 2014 15:15:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69BA82020F for ; Thu, 13 Nov 2014 15:15:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1AAFB201F4 for ; Thu, 13 Nov 2014 15:15:28 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 059B5265FDA; Thu, 13 Nov 2014 16:15:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 59A9326600E; Thu, 13 Nov 2014 16:14:40 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D6C5526048B; Thu, 13 Nov 2014 16:14:38 +0100 (CET) Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by alsa0.perex.cz (Postfix) with ESMTP id AB9EB26048B for ; Thu, 13 Nov 2014 16:14:30 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id kx10so15438496pab.20 for ; Thu, 13 Nov 2014 07:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=799vVjTKXGtF+KCLOg84VfTSJjfh7f5J09jFHoYCiF0=; b=G4+j5McfAklP+RDulmPSrgDy6vx6i/dHaxeV+B3efUuArZwKAOASOrNPtc2Yw0Sm2s ZbPrdl5K2WxPsRz2+IWGO2HvVVcTxT9MVDqr69zg3pGk068ih4mtUzI0/z1oiJOhsFuf qtW2WNqIl3XZk0inXPIQUb8c4PYornyC+5+U5oO7Z0YwfmRxNzYVJemxcWI2kKh/l++w oOeVX21FCLTVqgeTM2YjEUneqs7Rj8LLiHOjBmqXDlBomXY6oF5XTss1dqmG3bXxsMT4 AmIJiwC2I7oQ57NUZt3zlvm+NeRMZAB/o9kZdGBGZpBE/ptsujusdsXB4t6kANRFhT7U E1aA== X-Received: by 10.68.91.130 with SMTP id ce2mr2619236pbb.167.1415891669527; Thu, 13 Nov 2014 07:14:29 -0800 (PST) Received: from localhost.localdomain ([122.169.171.240]) by mx.google.com with ESMTPSA id kk1sm25158555pbd.14.2014.11.13.07.14.27 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Nov 2014 07:14:29 -0800 (PST) From: Sudip Mukherjee To: Takashi Iwai Date: Thu, 13 Nov 2014 20:44:17 +0530 Message-Id: <1415891657-7244-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1415891657-7244-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1415891657-7244-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: alsa-devel@alsa-project.org, Sudip Mukherjee , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 2/2] ALSA: ice1712: remove unused variable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP these variable were initialized with some value, but never used. and so they are safe to be deleted. Signed-off-by: Sudip Mukherjee --- i have not given Jaroslav Kysela in the To list, as in my last mail, all mails bounced with the error: "cant create user output file" sound/pci/ice1712/ice1712.c | 3 +-- sound/pci/ice1712/revo.c | 9 +++------ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c index b97a0f9..8f27357 100644 --- a/sound/pci/ice1712/ice1712.c +++ b/sound/pci/ice1712/ice1712.c @@ -620,10 +620,9 @@ static int snd_ice1712_playback_ds_prepare(struct snd_pcm_substream *substream) { struct snd_ice1712 *ice = snd_pcm_substream_chip(substream); struct snd_pcm_runtime *runtime = substream->runtime; - u32 period_size, buf_size, rate, tmp, chn; + u32 period_size, rate, tmp, chn; period_size = snd_pcm_lib_period_bytes(substream) - 1; - buf_size = snd_pcm_lib_buffer_bytes(substream) - 1; tmp = 0x0064; if (snd_pcm_format_width(runtime->format) == 16) tmp &= ~0x04; diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c index 1112ec1..1f40dab 100644 --- a/sound/pci/ice1712/revo.c +++ b/sound/pci/ice1712/revo.c @@ -481,7 +481,6 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) static const unsigned char ak4114_init_txcsb[] = { 0x41, 0x02, 0x2c, 0x00, 0x00 }; - int err; struct revo51_spec *spec; spec = kzalloc(sizeof(*spec), GFP_KERNEL); @@ -489,11 +488,9 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) return -ENOMEM; ice->spec = spec; - err = snd_ak4114_create(ice->card, - ap192_ak4114_read, - ap192_ak4114_write, - ak4114_init_vals, ak4114_init_txcsb, - ice, &spec->ak4114); + snd_ak4114_create(ice->card, ap192_ak4114_read, ap192_ak4114_write, + ak4114_init_vals, ak4114_init_txcsb, ice, + &spec->ak4114); /* AK4114 in Revo cannot detect external rate correctly. * No reason to stop capture stream due to incorrect checks */ spec->ak4114->check_flags = AK4114_CHECK_NO_RATE;