From patchwork Thu Nov 20 09:49:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Padmavathi Venna X-Patchwork-Id: 5346981 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C3FA89F2F1 for ; Thu, 20 Nov 2014 09:56:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 06B2D201F5 for ; Thu, 20 Nov 2014 09:56:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id C9ED620160 for ; Thu, 20 Nov 2014 09:56:55 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id D949F265964; Thu, 20 Nov 2014 10:56:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SUBJ_OBFU_PUNCT_MANY, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 61F972658B7; Thu, 20 Nov 2014 10:56:44 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 12F972658B7; Thu, 20 Nov 2014 10:56:43 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by alsa0.perex.cz (Postfix) with ESMTP id 5BA5426592A for ; Thu, 20 Nov 2014 10:56:29 +0100 (CET) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFC007FO0Y3OGD0@mailout4.samsung.com> for alsa-devel@alsa-project.org; Thu, 20 Nov 2014 18:56:27 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id D9.77.18484.BCABD645; Thu, 20 Nov 2014 18:56:27 +0900 (KST) X-AuditID: cbfee68f-f791c6d000004834-dd-546dbacb7d33 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B9.59.09430.ACABD645; Thu, 20 Nov 2014 18:56:27 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NFC00DH20WRIQD0@mmp2.samsung.com>; Thu, 20 Nov 2014 18:56:26 +0900 (KST) From: Padmavathi Venna To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org Date: Thu, 20 Nov 2014 15:19:37 +0530 Message-id: <1416476977-20118-1-git-send-email-padma.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrALMWRmVeSWpSXmKPExsWyRsSkVvf0rtwQg/v/uC2uXDzEZDH14RM2 i94FV9ksNj2+xmox4/w+JovDb9pZLS6u+MLkwO6x4XMTm8emVZ1sHpuX1Hv0bVnF6PF5k1wA axSXTUpqTmZZapG+XQJXRscmkYJpHBXXP39mb2A8wtbFyMkhIWAi8ev/DRYIW0ziwr31QHEu DiGBpYwS17echyv62PsNKjGdUWLPym8sEM4EJold108xdjFycLAJ6Ei0nHUBaRARyJLYPH09 2FRmgUKJe0tXgdULC/xgkpix5QwrSIJFQFVi75I5TCA2r4CzxLNnXcwgcyQEFCTmTLKBWPyf TWLhCiOIcgGJb5MPsUCUyEpsOsAMUSIpcXDFDZYJjIILGBlWMYqmFiQXFCelFxnrFSfmFpfm pesl5+duYgQG7Ol/z/p3MN49YH2IUYCDUYmHl8MsN0SINbGsuDL3EKMp0IaJzFKiyfnAuMgr iTc0NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOj0E/T/YWS 3z7oTp607KheXPqho7Pu8q5OP2LnfOtqMZfy8qnLJ3+JUfPuu7auu3jXGeX/XJUTLseYz1j7 zzik0XnJ3LW73dtu70qXWiDuInLt3IHkq5Mqay6/78gST7e4+pD32OxFv60+L9lToGhS8Uqr bsXMybOC7PcvYt9zZNr27zoXKmUPWCmxFGckGmoxFxUnAgBAWsqpUwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e+xoO7pXbkhBpM/MFlcuXiIyWLqwyds Fr0LrrJZbHp8jdVixvl9TBaH37SzWlxc8YXJgd1jw+cmNo9NqzrZPDYvqffo27KK0ePzJrkA 1qgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoDOU FMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBkdm0QKpnFUXP/8mb2B8Qhb FyMnh4SAicTH3m9QtpjEhXvrgWwuDiGB6YwSe1Z+Y4FwJjBJ7Lp+irGLkYODTUBHouWsC0iD iECWxObp61lAbGaBQol7S1eB1QsL/GCSmLHlDCtIgkVAVWLvkjlMIDavgLPEs2ddzCBzJAQU JOZMspnAyL2AkWEVo2hqQXJBcVJ6rpFecWJucWleul5yfu4mRnBEPJPewbiqweIQowAHoxIP b4JFbogQa2JZcWXuIUYJDmYlEV6NnUAh3pTEyqrUovz4otKc1OJDjKZAyycyS4km5wOjNa8k 3tDYxNzU2NTSxMLEzFJJnPf6KqAmgfTEktTs1NSC1CKYPiYOTqkGRrOlOUq21hW7BObO6td6 vPjcgcaYwsr5KgoccxyEuKafYX+vpB3u++u0zPb7bk5n0g+GPP2p0X+MdY+J04LJs26dP5h1 l7HrlXUtlwTLX6vHW3c9+vi/TSZ2tZXN9k/Sn7bXvcluP3qx+wVD1b3/mW7m8pc/Nl18eCEi xtJp6k69F2eW787suqPEUpyRaKjFXFScCABHgN15ngIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: sbkim73@samsung.com, kgene.kim@samsung.com, broonie@kernel.org, Sylwester Nawrocki Subject: [alsa-devel] [PATCH] ASoC: samsung: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND operation which is introduced in commit a5a56871f804edac93a53b5e871c0e9818fb9033 (ASoC: samsung: add support for exynos7 I2S controller) and also adds the missing break statement. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Cc: Sylwester Nawrocki Signed-off-by: Sylwester Nawrocki Signed-off-by: Padmavathi Venna --- sound/soc/samsung/i2s.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 0df6547..e1ace52 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -494,7 +494,7 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai, if (dir == SND_SOC_CLOCK_IN) mod |= 1 << i2s_regs->cdclkcon_off; else - mod &= 0 << i2s_regs->cdclkcon_off; + mod &= ~(1 << i2s_regs->cdclkcon_off); i2s->rfs = rfs; break; @@ -551,10 +551,11 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai, } if (clk_id == 0) - mod &= 0 << i2s_regs->rclksrc_off; + mod &= ~(1 << i2s_regs->rclksrc_off); else mod |= 1 << i2s_regs->rclksrc_off; + break; default: dev_err(&i2s->pdev->dev, "We don't serve that!\n"); return -EINVAL;