| Message ID | 1418034191-28010-1-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5ede19c58a1ec274b28e03a76b855c3c55ab6f11 |
| Headers | show |
On Mon, Dec 08, 2014 at 11:23:11AM +0100, Lars-Peter Clausen wrote: > Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the > previously missing VREF widget. And while adding the widget as OUTPUT widget > silences the error of the missing widget it should have rather been a VMID > widget. > > The VREF widget is only used internally as a source for the VREF input of > the Out3 Mux. Selecting that input means that the path should be kept > powered up at the VREF/VMID voltage, but that there is no actual audio > signal. Using a VMID widget will do this, whereas using a OUTPUT widget will > simply cause the path to completely power down. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
On Mon, Dec 08, 2014 at 11:23:11AM +0100, Lars-Peter Clausen wrote: > Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the > previously missing VREF widget. And while adding the widget as OUTPUT widget > silences the error of the missing widget it should have rather been a VMID > widget. Applied, thanks.
diff --git a/sound/soc/codecs/wm8750.c b/sound/soc/codecs/wm8750.c index f6847fd..eb0a164 100644 --- a/sound/soc/codecs/wm8750.c +++ b/sound/soc/codecs/wm8750.c @@ -323,7 +323,7 @@ static const struct snd_soc_dapm_widget wm8750_dapm_widgets[] = { SND_SOC_DAPM_OUTPUT("ROUT2"), SND_SOC_DAPM_OUTPUT("MONO1"), SND_SOC_DAPM_OUTPUT("OUT3"), - SND_SOC_DAPM_OUTPUT("VREF"), + SND_SOC_DAPM_VMID("VREF"), SND_SOC_DAPM_INPUT("LINPUT1"), SND_SOC_DAPM_INPUT("LINPUT2"),
Commit 04489eeb02a4 ("ALSA: wm8750: add missing VREF output") added the previously missing VREF widget. And while adding the widget as OUTPUT widget silences the error of the missing widget it should have rather been a VMID widget. The VREF widget is only used internally as a source for the VREF input of the Out3 Mux. Selecting that input means that the path should be kept powered up at the VREF/VMID voltage, but that there is no actual audio signal. Using a VMID widget will do this, whereas using a OUTPUT widget will simply cause the path to completely power down. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/codecs/wm8750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)