| Message ID | 1418989110-10011-1-git-send-email-qais.yousef@imgtec.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7b617289b699b5f7e4544bfd2794818cb880b928 |
| Headers | show |
Ping On 12/19/2014 11:38 AM, Qais Yousef wrote: > Fixes the following compilation error: > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] > if (snd_BUG_ON(!stream)) > > snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, > so include it. > > Signed-off-by: Qais Yousef <qais.yousef@imgtec.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.de> > Cc: linux-kernel@vger.kernel.org > > --- > include/sound/compress_driver.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h > index 396e8f73670a..1e2531058b7e 100644 > --- a/include/sound/compress_driver.h > +++ b/include/sound/compress_driver.h > @@ -27,6 +27,7 @@ > > #include <linux/types.h> > #include <linux/sched.h> > +#include <sound/core.h> > #include <sound/compress_offload.h> > #include <sound/asound.h> > #include <sound/pcm.h>
On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote: > Ping > > On 12/19/2014 11:38 AM, Qais Yousef wrote: > >Fixes the following compilation error: > > > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: > > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] > > if (snd_BUG_ON(!stream)) > > > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, > >so include it. > > > >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com> > >Cc: Vinod Koul <vinod.koul@intel.com> > >Cc: Jaroslav Kysela <perex@perex.cz> > >Cc: Takashi Iwai <tiwai@suse.de> > >Cc: linux-kernel@vger.kernel.org > > Looks okay to me Acked-by: Vinod Koul <vinod.koul@intel.com> Thanks
At Tue, 13 Jan 2015 20:15:49 +0530, Vinod Koul wrote: > > On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote: > > Ping > > > > On 12/19/2014 11:38 AM, Qais Yousef wrote: > > >Fixes the following compilation error: > > > > > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: > > > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] > > > if (snd_BUG_ON(!stream)) > > > > > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, > > >so include it. > > > > > >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com> > > >Cc: Vinod Koul <vinod.koul@intel.com> > > >Cc: Jaroslav Kysela <perex@perex.cz> > > >Cc: Takashi Iwai <tiwai@suse.de> > > >Cc: linux-kernel@vger.kernel.org > > > > Looks okay to me > > Acked-by: Vinod Koul <vinod.koul@intel.com> Applied now. Thanks. Takashi
diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h index 396e8f73670a..1e2531058b7e 100644 --- a/include/sound/compress_driver.h +++ b/include/sound/compress_driver.h @@ -27,6 +27,7 @@ #include <linux/types.h> #include <linux/sched.h> +#include <sound/core.h> #include <sound/compress_offload.h> #include <sound/asound.h> #include <sound/pcm.h>
Fixes the following compilation error: include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] if (snd_BUG_ON(!stream)) snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, so include it. Signed-off-by: Qais Yousef <qais.yousef@imgtec.com> Cc: Vinod Koul <vinod.koul@intel.com> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.de> Cc: linux-kernel@vger.kernel.org --- include/sound/compress_driver.h | 1 + 1 file changed, 1 insertion(+)