| Message ID | 1419095004-9727-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
At Sat, 20 Dec 2014 18:03:24 +0100, Rickard Strandqvist wrote: > > Remove the function snd_gus_simple_remove_sample() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> The whole instrument manager function was dropped many years ago, but this file and functions are left for the future (re-)implementation. But judging from the current situation, the chance that we'll get a new feature for GUS boards is quite low, so rather we should simply delete this file. The developer can still refer to the git repository as a reference. Will do that for for-next branch. thanks, Takashi > --- > sound/isa/gus/gus_instr.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/sound/isa/gus/gus_instr.c b/sound/isa/gus/gus_instr.c > index 4dc9caf..2d21408 100644 > --- a/sound/isa/gus/gus_instr.c > +++ b/sound/isa/gus/gus_instr.c > @@ -162,11 +162,3 @@ int snd_gus_simple_get_sample(void *private_data, struct simple_instrument *inst > > return snd_gus_dram_read(gus, data, instr->address.memory, instr->size, 0); > } > - > -int snd_gus_simple_remove_sample(void *private_data, struct simple_instrument *instr, > - int atomic) > -{ > - struct snd_gus_card *gus = private_data; > - > - return snd_gf1_mem_free(&gus->gf1.mem_alloc, instr->address.memory); > -} > -- > 1.7.10.4 >
diff --git a/sound/isa/gus/gus_instr.c b/sound/isa/gus/gus_instr.c index 4dc9caf..2d21408 100644 --- a/sound/isa/gus/gus_instr.c +++ b/sound/isa/gus/gus_instr.c @@ -162,11 +162,3 @@ int snd_gus_simple_get_sample(void *private_data, struct simple_instrument *inst return snd_gus_dram_read(gus, data, instr->address.memory, instr->size, 0); } - -int snd_gus_simple_remove_sample(void *private_data, struct simple_instrument *instr, - int atomic) -{ - struct snd_gus_card *gus = private_data; - - return snd_gf1_mem_free(&gus->gf1.mem_alloc, instr->address.memory); -}
Remove the function snd_gus_simple_remove_sample() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- sound/isa/gus/gus_instr.c | 8 -------- 1 file changed, 8 deletions(-)