From patchwork Fri Jan 2 17:58:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5560271 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C63019F2ED for ; Fri, 2 Jan 2015 17:55:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBBBA20256 for ; Fri, 2 Jan 2015 17:55:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1E24C201FB for ; Fri, 2 Jan 2015 17:55:54 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5210726055E; Fri, 2 Jan 2015 18:55:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 7884B26052E; Fri, 2 Jan 2015 18:55:39 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 639E726053E; Fri, 2 Jan 2015 18:55:38 +0100 (CET) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by alsa0.perex.cz (Postfix) with ESMTP id 1739A26052E for ; Fri, 2 Jan 2015 18:55:27 +0100 (CET) Received: by mail-wg0-f53.google.com with SMTP id x13so6626054wgg.40 for ; Fri, 02 Jan 2015 09:55:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZcISW5KoaqEdT+ZDtdFD63oSmcB61J1fpHRJa0clJD4=; b=OZyehNr4KPqtH0LDsOVW00iS2Ux49hyb0DHDyiIwC8c8v8DfwKN9GCjLb6McLxkZRV zYh4RCrbYcPOppBSxoEQnTqtrw3ccJUbna8q2dVHDMlK93X7Slch5gJ88WjEIIL80/Ig r9d7tqQrU+/x1oCw52zmlnkAn1HsRYY/3yjegBbfwiCXAuNZ13Zp0dToptrTEAPcLO61 RfegCUmES0beyFAj2R5/jilW5WZ5Mj0bygSYHJ4SBC/dDFWFQWewWGfLcZwSrXnqKZZZ HN4exnByRvTsGP7OJDBL6gl7VagjGVybjXhDZc6BstcIHoqO3mRzfmiz7XaryRgw/TAX Bd6w== X-Gm-Message-State: ALoCoQmFi5rt5suTGPHhNFZVkOyWnWbkNreSIR4wXFWwpQdCn3zFJ3J3TwMVpu9N90l0EamuwxDX X-Received: by 10.194.91.145 with SMTP id ce17mr69558440wjb.132.1420221326591; Fri, 02 Jan 2015 09:55:26 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id a1sm16532671wjx.28.2015.01.02.09.55.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jan 2015 09:55:25 -0800 (PST) From: Rickard Strandqvist To: Jaroslav Kysela , Takashi Iwai Date: Fri, 2 Jan 2015 18:58:28 +0100 Message-Id: <1420221508-32319-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Rickard Strandqvist Subject: [alsa-devel] [PATCH] sound: pci: hda: patch_analog: Remove some unused functions X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Removes some functions that are not used anywhere: ad198x_ch_mode_put() ad198x_ch_mode_info() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- sound/pci/hda/patch_analog.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 06275f8..ed0b71c 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -698,15 +698,6 @@ static int patch_ad1981(struct hda_codec *codec) */ #ifdef ENABLE_AD_STATIC_QUIRKS -static int ad198x_ch_mode_info(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_info *uinfo) -{ - struct hda_codec *codec = snd_kcontrol_chip(kcontrol); - struct ad198x_spec *spec = codec->spec; - return snd_hda_ch_mode_info(codec, uinfo, spec->channel_mode, - spec->num_channel_mode); -} - static int ad198x_ch_mode_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -716,18 +707,6 @@ static int ad198x_ch_mode_get(struct snd_kcontrol *kcontrol, spec->num_channel_mode, spec->multiout.max_channels); } -static int ad198x_ch_mode_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct hda_codec *codec = snd_kcontrol_chip(kcontrol); - struct ad198x_spec *spec = codec->spec; - int err = snd_hda_ch_mode_put(codec, ucontrol, spec->channel_mode, - spec->num_channel_mode, - &spec->multiout.max_channels); - if (err >= 0 && spec->need_dac_fix) - spec->multiout.num_dacs = spec->multiout.max_channels / 2; - return err; -} #endif /* ENABLE_AD_STATIC_QUIRKS */ static int ad1988_auto_smux_enum_info(struct snd_kcontrol *kcontrol,