From patchwork Wed Jan 7 21:45:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5588441 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0F9E19F1C5 for ; Wed, 7 Jan 2015 21:46:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 42726202EB for ; Wed, 7 Jan 2015 21:46:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 12B63202A1 for ; Wed, 7 Jan 2015 21:46:25 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4C7062652AE; Wed, 7 Jan 2015 22:46:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NO_DNS_FOR_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id DD1E026525B; Wed, 7 Jan 2015 22:46:15 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id DBED526525F; Wed, 7 Jan 2015 22:46:13 +0100 (CET) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by alsa0.perex.cz (Postfix) with ESMTP id D4552265253 for ; Wed, 7 Jan 2015 22:46:06 +0100 (CET) Received: by mail-vc0-f174.google.com with SMTP id id10so835976vcb.19 for ; Wed, 07 Jan 2015 13:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=buUwTUf5CIG0ybSECX2uiCkS/nO+oePcIboVKfAb2b4=; b=VGwb6reWJJloPb4ELoQXvZEqyeu3858hCX0Fcyaz/7c9GRn3JKTXKU7K8zSLEU4Ayi wqw5lLK3FyRQvNgx2/tN03D0TQzn56CG4aUr9iVL8Duk5SkJnatZHeaNxV0tv43s98nm 5DyyMEKYs+5Kn8scUlOGNSvLen5PrH1APEv6iKOlEhO0b0aenEpJjZOPwA62QSbZvt4Q DaDXLyHnO6/jWbhkasouaShhO2lUkrnwXZfrzUxSidL0BZ01KFBVaNugxhQJn3VAHwOF UbC/hTXNFmzxu7xtVBRfGcDFygiIjoo+tdEk58G5i/Xx5b7SdOt+xNxST2z2tY1ZKHuE +Zfw== X-Received: by 10.52.171.81 with SMTP id as17mr4102587vdc.83.1420667165532; Wed, 07 Jan 2015 13:46:05 -0800 (PST) Received: from localhost.localdomain ([179.159.214.140]) by mx.google.com with ESMTPSA id l11sm823265vdh.16.2015.01.07.13.46.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Jan 2015 13:46:04 -0800 (PST) From: Fabio Estevam To: broonie@kernel.org Date: Wed, 7 Jan 2015 19:45:40 -0200 Message-Id: <1420667140-32744-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: nicoleotsuka@gmail.com, Fabio Estevam , alsa-devel@alsa-project.org, timur@tabi.org Subject: [alsa-devel] [PATCH] ASoC: fsl_ssi: Fix irq error check X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Commit 2ffa531078037a0 ("ASoC: fsl_ssi: Fix module unbound") changed the way to retrieve the irq number from irq_of_parse_and_map() to platform_get_irq(), but missed to updated the irq error check accordingly. We should test for negative irq number and propagate it in the case of error. Signed-off-by: Fabio Estevam --- sound/soc/fsl/fsl_ssi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index a65f17d..059496e 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1362,9 +1362,9 @@ static int fsl_ssi_probe(struct platform_device *pdev) } ssi_private->irq = platform_get_irq(pdev, 0); - if (!ssi_private->irq) { + if (ssi_private->irq < 0) { dev_err(&pdev->dev, "no irq for node %s\n", np->full_name); - return -ENXIO; + return ssi_private->irq; } /* Are the RX and the TX clocks locked? */