From patchwork Sat Jan 10 16:53:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5605051 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 34E569F357 for ; Sat, 10 Jan 2015 16:50:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 424FC2062C for ; Sat, 10 Jan 2015 16:50:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 5FD192044C for ; Sat, 10 Jan 2015 16:50:13 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 39E65260591; Sat, 10 Jan 2015 17:50:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 23A4F260421; Sat, 10 Jan 2015 17:50:03 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id EFBD1260573; Sat, 10 Jan 2015 17:50:01 +0100 (CET) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by alsa0.perex.cz (Postfix) with ESMTP id 0E330260415 for ; Sat, 10 Jan 2015 17:49:54 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id n3so7691830wiv.1 for ; Sat, 10 Jan 2015 08:49:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EcLeIvkCvgO8hzG1pugE3K1aBc4HnmQHfokm4eS2acE=; b=CyhQC6Ge9iQPLhXBQekmHo98npilFKwyUCVXk6pZVEnkUUaaurjDXiBdkqijd6/dez p2eB/Jl+WkWC7nekJsCbhHcgTuI28a5JSBdeOHJq2C/v4FSesSgKM0XUrJMnDHrx9ZUZ 3iGSpE6OkDtzwuF5AT+Oa/Gt2wqXlhdj4hmGp9cN3Ny0v8eFyKSUIHtgTvth6Wtk/agt AevzDkXN49IgUA1lxNkEm/tenk2KGdqRw7n5m8SLttyL+SqKCnuQcvfhRsex6kGZcNzU g3OTepEO0qNjLYuQRHii5jXjg3aivqOOXF8Fa9grFQYPZNM2UWV7fXxfpkjilfV8PmZ9 XWyQ== X-Gm-Message-State: ALoCoQncaxQ71FscR/aRcoLYG3WFlAXjLYMiHODe1eJN8pm6RoJbHM9AC43U2ZEFMNBLHKselWZG X-Received: by 10.194.48.109 with SMTP id k13mr13491651wjn.7.1420908594561; Sat, 10 Jan 2015 08:49:54 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id bo3sm14301373wjb.44.2015.01.10.08.49.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jan 2015 08:49:53 -0800 (PST) From: Rickard Strandqvist To: Clemens Ladisch , Jaroslav Kysela Date: Sat, 10 Jan 2015 17:53:00 +0100 Message-Id: <1420908780-31468-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Cc: Takashi Iwai , alsa-devel@alsa-project.org, Takashi Sakamoto , linux-kernel@vger.kernel.org, Rickard Strandqvist Subject: [alsa-devel] [PATCH] sound: firewire: fireworks: fireworks_command: Remove unused function X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function snd_efw_command_set_resp_addr() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- sound/firewire/fireworks/fireworks.h | 2 -- sound/firewire/fireworks/fireworks_command.c | 21 --------------------- 2 files changed, 23 deletions(-) diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h index 4f0201a..693b76b 100644 --- a/sound/firewire/fireworks/fireworks.h +++ b/sound/firewire/fireworks/fireworks.h @@ -189,8 +189,6 @@ enum snd_efw_transport_mode { SND_EFW_TRANSPORT_MODE_WINDOWS = 0, SND_EFW_TRANSPORT_MODE_IEC61883 = 1, }; -int snd_efw_command_set_resp_addr(struct snd_efw *efw, - u16 addr_high, u32 addr_low); int snd_efw_command_set_tx_mode(struct snd_efw *efw, enum snd_efw_transport_mode mode); int snd_efw_command_get_hwinfo(struct snd_efw *efw, diff --git a/sound/firewire/fireworks/fireworks_command.c b/sound/firewire/fireworks/fireworks_command.c index 166f805..e0cc467 100644 --- a/sound/firewire/fireworks/fireworks_command.c +++ b/sound/firewire/fireworks/fireworks_command.c @@ -175,27 +175,6 @@ end: } /* - * The address in host system for transaction response is changable when the - * device supports. struct hwinfo.flags includes its flag. The default is - * MEMORY_SPACE_EFW_RESPONSE. - */ -int snd_efw_command_set_resp_addr(struct snd_efw *efw, - u16 addr_high, u32 addr_low) -{ - __be32 addr[2]; - - addr[0] = cpu_to_be32(addr_high); - addr[1] = cpu_to_be32(addr_low); - - if (!efw->resp_addr_changable) - return -ENOSYS; - - return efw_transaction(efw, EFC_CAT_HWCTL, - EFC_CMD_HWINFO_SET_RESP_ADDR, - addr, sizeof(addr), NULL, 0); -} - -/* * This is for timestamp processing. In Windows mode, all 32bit fields of second * CIP header in AMDTP transmit packet is used for 'presentation timestamp'. In * 'no data' packet the value of this field is 0x90ffffff.