| Message ID | 1422278138-51097-3-git-send-email-Zubair.Kakakhel@imgtec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 26 January 2015 13:15:36 Zubair Lutfullah Kakakhel wrote: > + > +Required properties: > +- compatible : "ingenic,jz4740-i2s" > +- reg : I2S registers location and length > +- clocks : AIC and I2S PLL clock specifiers. > +- clock-names: "aic" and "i2s" > + > +Example: > + > +i2s: i2s@10020000 { > + compatible = "ingenic,jz4740-i2s"; > + reg = <0x10020000 0x94>; > + > + clocks = <&cgu JZ4740_CLK_AIC>, <&cgu JZ4740_CLK_I2SPLL>; > + clock-names = "aic", "i2s"; > + > + dmas = <&dma 2>, <&dma 3>; > + dma-names = "tx", "rx"; > + > Thanks for adding the dma entries to the example. Unfortunately you have missed adding them to the list of required properties, so please add those as well. Arnd
diff --git a/Documentation/devicetree/bindings/sound/ingenic,jz4740-i2s.txt b/Documentation/devicetree/bindings/sound/ingenic,jz4740-i2s.txt new file mode 100644 index 0000000..75206cd --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ingenic,jz4740-i2s.txt @@ -0,0 +1,21 @@ +Ingenic JZ4740 I2S controller + +Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : AIC and I2S PLL clock specifiers. +- clock-names: "aic" and "i2s" + +Example: + +i2s: i2s@10020000 { + compatible = "ingenic,jz4740-i2s"; + reg = <0x10020000 0x94>; + + clocks = <&cgu JZ4740_CLK_AIC>, <&cgu JZ4740_CLK_I2SPLL>; + clock-names = "aic", "i2s"; + + dmas = <&dma 2>, <&dma 3>; + dma-names = "tx", "rx"; + +};
This patch adds binding for the jz4740-i2s driver. Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> --- The jz4740 is platform only at the moment. But DT support is being added See http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/ V2 changes: Added DMA bindings for later on --- .../bindings/sound/ingenic,jz4740-i2s.txt | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ingenic,jz4740-i2s.txt