diff mbox

[4/6] ALSA: line6: Return EIO if read/write not successful

Message ID 1423630997-25464-5-git-send-email-chris@rorvick.com (mailing list archive)
State Accepted
Commit e474e7fd404b9e516f1c90a1c3f485e21be34c15
Headers show

Commit Message

Chris Rorvick Feb. 11, 2015, 5:03 a.m. UTC 
Signed-off-by: Chris Rorvick <chris@rorvick.com>
---
 sound/usb/line6/driver.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Takashi Iwai Feb. 11, 2015, 9:43 a.m. UTC | #1 
At Tue, 10 Feb 2015 23:03:15 -0600,
Chris Rorvick wrote:
> 
> Signed-off-by: Chris Rorvick <chris@rorvick.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/line6/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index 2a33f3e..f8e2eb0 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -349,7 +349,7 @@ int line6_read_data(struct usb_line6 *line6, u16 address, void *data,
>  		dev_err(line6->ifcdev,
>  			"length mismatch (expected %d, got %d)\n",
>  			(int)datalen, (int)len);
> -		return -EINVAL;
> +		return -EIO;
>  	}
>  
>  	/* receive the result: */
> @@ -415,7 +415,7 @@ int line6_write_data(struct usb_line6 *line6, u16 address, void *data,
>  		return -EIO;
>  	} else if (status != 0) {
>  		dev_err(line6->ifcdev, "write failed (error %d)\n", ret);
> -		return -EINVAL;
> +		return -EIO;
>  	}
>  
>  	return 0;
> -- 
> 2.1.0
>
diff mbox

Patch

diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
index 2a33f3e..f8e2eb0 100644
--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -349,7 +349,7 @@  int line6_read_data(struct usb_line6 *line6, u16 address, void *data,
 		dev_err(line6->ifcdev,
 			"length mismatch (expected %d, got %d)\n",
 			(int)datalen, (int)len);
-		return -EINVAL;
+		return -EIO;
 	}
 
 	/* receive the result: */
@@ -415,7 +415,7 @@  int line6_write_data(struct usb_line6 *line6, u16 address, void *data,
 		return -EIO;
 	} else if (status != 0) {
 		dev_err(line6->ifcdev, "write failed (error %d)\n", ret);
-		return -EINVAL;
+		return -EIO;
 	}
 
 	return 0;