From patchwork Wed Feb 11 05:03:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rorvick X-Patchwork-Id: 5810331 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E5B269F30C for ; Wed, 11 Feb 2015 05:06:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3AAEC2021A for ; Wed, 11 Feb 2015 05:06:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id D7F8020218 for ; Wed, 11 Feb 2015 05:06:49 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id EEDA22625FE; Wed, 11 Feb 2015 06:06:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 0A9F0260631; Wed, 11 Feb 2015 06:03:59 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BDFD32617AD; Wed, 11 Feb 2015 06:03:57 +0100 (CET) Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com [209.85.213.177]) by alsa0.perex.cz (Postfix) with ESMTP id E43DC260631 for ; Wed, 11 Feb 2015 06:03:43 +0100 (CET) Received: by mail-ig0-f177.google.com with SMTP id z20so2221326igj.4 for ; Tue, 10 Feb 2015 21:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=UfTkIyGRxVeGYQpSpJRx5ZFbWPhS6+5qj9nn/CceRO4=; b=OZqjFAwnAFCKOpLAcBtn0W4NeQHJbwmGWNkrhVre+4+PAFxY1ORMIZjjayeyaQ76Av VqIo3+5MNOWEbOlU4+IcnNJouk1IOW/F2Cg6482DGhsDXIzNHXMey8v8hQGq0oUnXwia hnXL3v8znmxqb868YVSfz4N5lFVAQ8tiHfEarOtCixwNsbW/9N9RVvy0p+jfi8L1a5un nkgEe/9dwkCx4syQCS3MEMRK2qeqm0se/dT5Zgr4qjkQ0mtUherkdegvrnFNY4Ufpag8 agqKLGXWr5Ih8lsHRLBc11Kr4z8bPnJL2PInIMU7nxk2UeubSg4K++wUgG4s7M9/bLuJ 1NRQ== X-Received: by 10.107.136.24 with SMTP id k24mr21430407iod.59.1423631023159; Tue, 10 Feb 2015 21:03:43 -0800 (PST) Received: from localhost.localdomain.com ([99.135.164.179]) by mx.google.com with ESMTPSA id qd2sm9291297igc.22.2015.02.10.21.03.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Feb 2015 21:03:42 -0800 (PST) From: Chris Rorvick To: Takashi Iwai Date: Tue, 10 Feb 2015 23:03:17 -0600 Message-Id: <1423630997-25464-7-git-send-email-chris@rorvick.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1423630997-25464-1-git-send-email-chris@rorvick.com> References: <1423630997-25464-1-git-send-email-chris@rorvick.com> Cc: Stefan Hajnoczi , alsa-devel@alsa-project.org, Chris Rorvick , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The firmware version is a single byte so have the variable type agree. Since the address to this member is passed to the read function, using an int is not even portable. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c index ddf7368..6d4c50c 100644 --- a/sound/usb/line6/toneport.c +++ b/sound/usb/line6/toneport.c @@ -52,7 +52,7 @@ struct usb_line6_toneport { u32 serial_number; /* Firmware version (x 100) */ - int firmware_version; + u8 firmware_version; /* Timer for delayed PCM startup */ struct timer_list timer;