diff mbox

ALSA: firewire-lib: fix an unexpected byte sequence for micro sign

Message ID 1424487017-24434-1-git-send-email-o-takashi@sakamocchi.jp (mailing list archive)
State Accepted
Commit ca5b50501d6486bfbb73a07ed8b8821fb31dc065
Headers show

Commit Message

Takashi Sakamoto Feb. 21, 2015, 2:50 a.m. UTC
The sign for microsecond (U+0085, MICRO SIGN) was encoded to '0x c2 b5'
by UTF-8 character encoding scheme. But the byte sequence was converted
to '0x c3 82 c2 b5' in a previous commit. As a result, the byte
sequence cannot represent microsecond sign in UTF-8 or ASCII. This
may confuse developers.

This commit replaces the sign to string expression with 'microseconds'
to purge superfluous troubles.

Fixes: 5c697e5b46ef("ALSA: firewire-lib: remove rx_blocks_for_midi quirk")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/amdtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Feb. 21, 2015, 7:56 a.m. UTC | #1
At Sat, 21 Feb 2015 11:50:17 +0900,
Takashi Sakamoto wrote:
> 
> The sign for microsecond (U+0085, MICRO SIGN) was encoded to '0x c2 b5'
> by UTF-8 character encoding scheme. But the byte sequence was converted
> to '0x c3 82 c2 b5' in a previous commit. As a result, the byte
> sequence cannot represent microsecond sign in UTF-8 or ASCII. This
> may confuse developers.
> 
> This commit replaces the sign to string expression with 'microseconds'
> to purge superfluous troubles.
> 
> Fixes: 5c697e5b46ef("ALSA: firewire-lib: remove rx_blocks_for_midi quirk")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/firewire/amdtp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/firewire/amdtp.c b/sound/firewire/amdtp.c
> index 0d58018..7b7b183 100644
> --- a/sound/firewire/amdtp.c
> +++ b/sound/firewire/amdtp.c
> @@ -33,7 +33,7 @@
>   */
>  #define MAX_MIDI_RX_BLOCKS	8
>  
> -#define TRANSFER_DELAY_TICKS	0x2e00 /* 479.17 µs */
> +#define TRANSFER_DELAY_TICKS	0x2e00 /* 479.17 microseconds */
>  
>  /* isochronous header parameters */
>  #define ISO_DATA_LENGTH_SHIFT	16
> -- 
> 2.1.0
>
diff mbox

Patch

diff --git a/sound/firewire/amdtp.c b/sound/firewire/amdtp.c
index 0d58018..7b7b183 100644
--- a/sound/firewire/amdtp.c
+++ b/sound/firewire/amdtp.c
@@ -33,7 +33,7 @@ 
  */
 #define MAX_MIDI_RX_BLOCKS	8
 
-#define TRANSFER_DELAY_TICKS	0x2e00 /* 479.17 µs */
+#define TRANSFER_DELAY_TICKS	0x2e00 /* 479.17 microseconds */
 
 /* isochronous header parameters */
 #define ISO_DATA_LENGTH_SHIFT	16