diff mbox

ASoC: cs4271: Increase delay time after reset

Message ID 1427962660-23517-1-git-send-email-pascal.huerst@gmail.com (mailing list archive)
State Accepted
Commit 74ff960222d90999508b4ba0d3449f796695b6d5
Headers show

Commit Message

Pascal Huerst April 2, 2015, 8:17 a.m. UTC 
From: Pascal Huerst <pascal.huerst@gmail.com>

The delay time after a reset in the codec probe callback was too short,
and did not work on certain hw because the codec needs more time to
power on. This increases the delay time from 1us to 1ms.

Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
---
 sound/soc/codecs/cs4271.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Austin, Brian April 2, 2015, 2:15 p.m. UTC | #1 
On Thu, 2 Apr 2015, pascal.huerst@gmail.com wrote:

> From: Pascal Huerst <pascal.huerst@gmail.com>
> 
> The delay time after a reset in the codec probe callback was too short,
> and did not work on certain hw because the codec needs more time to
> power on. This increases the delay time from 1us to 1ms.
> 
> Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
Thanks for the patch.

Acked-by: Brian Austin <brian.austin@cirrus.com>
Mark Brown April 2, 2015, 5:15 p.m. UTC | #2 
On Thu, Apr 02, 2015 at 10:17:40AM +0200, pascal.huerst@gmail.com wrote:
> From: Pascal Huerst <pascal.huerst@gmail.com>
> 
> The delay time after a reset in the codec probe callback was too short,
> and did not work on certain hw because the codec needs more time to
> power on. This increases the delay time from 1us to 1ms.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index 7d3a6ac..e770ee6 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -561,10 +561,10 @@  static int cs4271_codec_probe(struct snd_soc_codec *codec)
 	if (gpio_is_valid(cs4271->gpio_nreset)) {
 		/* Reset codec */
 		gpio_direction_output(cs4271->gpio_nreset, 0);
-		udelay(1);
+		mdelay(1);
 		gpio_set_value(cs4271->gpio_nreset, 1);
 		/* Give the codec time to wake up */
-		udelay(1);
+		mdelay(1);
 	}
 
 	ret = regmap_update_bits(cs4271->regmap, CS4271_MODE2,