From patchwork Thu Apr 2 09:57:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 6146061 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2982CBF4A6 for ; Thu, 2 Apr 2015 10:02:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43BA920386 for ; Thu, 2 Apr 2015 10:02:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 46DBC20373 for ; Thu, 2 Apr 2015 10:02:43 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7B7882657B8; Thu, 2 Apr 2015 12:02:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id ADBA12654D8; Thu, 2 Apr 2015 12:02:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id AD2DE2604F4; Thu, 2 Apr 2015 12:02:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by alsa0.perex.cz (Postfix) with ESMTP id 7B1952604CA for ; Thu, 2 Apr 2015 12:02:01 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 02 Apr 2015 03:02:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,510,1422950400"; d="scan'208";a="707846808" Received: from vkoul-udesk3.iind.intel.com ([10.223.84.65]) by orsmga002.jf.intel.com with ESMTP; 02 Apr 2015 03:01:57 -0700 From: Vinod Koul To: alsa-devel@alsa-project.org Date: Thu, 2 Apr 2015 15:27:29 +0530 Message-Id: <1427968651-7821-2-git-send-email-vinod.koul@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1427968651-7821-1-git-send-email-vinod.koul@intel.com> References: <1427968651-7821-1-git-send-email-vinod.koul@intel.com> Cc: tiwai@suse.de, lgirdwood@gmail.com, Ramesh Babu , Vinod Koul , broonie@kernel.org, pathes.audio@intel.com Subject: [alsa-devel] [RFC 1/3] ALSA: hda - remove assigning dev type inside core X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ramesh Babu We don't need to init the hda dev type inside core device init code. It is expected to be initialized by the caller. Signed-off-by: Ramesh Babu Signed-off-by: Vinod Koul --- sound/hda/hdac_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c index 6e8ee1d6974a..aefc80ffecee 100644 --- a/sound/hda/hdac_device.c +++ b/sound/hda/hdac_device.c @@ -51,7 +51,6 @@ int snd_hdac_device_init(struct hdac_device *codec, struct hdac_bus *bus, codec->bus = bus; codec->addr = addr; - codec->type = HDA_DEV_CORE; pm_runtime_set_active(&codec->dev); pm_runtime_get_noresume(&codec->dev); atomic_set(&codec->in_pm, 0);