| Message ID | 1428906054-17613-1-git-send-email-yao.jin@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac98b4c015b50b1e452f8d55b612320be7f80825 |
| Headers | show |
On Mon, Apr 13, 2015 at 02:20:54PM +0800, Jin Yao wrote: > kbuild robot reports following warning: > "sound/soc/intel/haswell/sst-haswell-ipc.c:2204:1-6: > WARNING: invalid free of devm_ allocated data" Appied, thanks.
diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c index 344a1e9..324eceb 100644 --- a/sound/soc/intel/haswell/sst-haswell-ipc.c +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c @@ -2201,7 +2201,6 @@ dma_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err: - kfree(hsw); return ret; } EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
kbuild robot reports following warning: "sound/soc/intel/haswell/sst-haswell-ipc.c:2204:1-6: WARNING: invalid free of devm_ allocated data" As julia explains to me, the memory allocated with devm_kalloc is freed automatically on failure of a probe function. So this kfree should be removed otherwise the double free will be got in error handler path. Signed-off-by: Jin Yao <yao.jin@linux.intel.com> --- sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - 1 file changed, 1 deletion(-)