diff mbox

[13/13] ASoC: wm_adsp: Warn that firmware file format 0 is depreciated

Message ID 1428928085-20250-14-git-send-email-ckeepax@opensource.wolfsonmicro.com (mailing list archive)
State Accepted
Commit c61e59fe4d3432dd8e63b9613895150eb5054d5e
Headers show

Commit Message

Charles Keepax April 13, 2015, 12:28 p.m. UTC
There are very few version 0 firmwares in the wild and at some point in
the future it would be nice to remove support for them from the driver,
as they require several work arounds to be present to create controls
properly.

This patch adds a depreciated warning if someone is using this file
format.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm_adsp.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Mark Brown April 18, 2015, 5:26 p.m. UTC | #1
On Mon, Apr 13, 2015 at 01:28:05PM +0100, Charles Keepax wrote:
> There are very few version 0 firmwares in the wild and at some point in
> the future it would be nice to remove support for them from the driver,
> as they require several work arounds to be present to create controls
> properly.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index a5dd22e..173f332 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -935,6 +935,9 @@  static int wm_adsp_load(struct wm_adsp *dsp)
 
 	switch (header->ver) {
 	case 0:
+		adsp_warn(dsp, "%s: Depreciated file format %d\n",
+			  file, header->ver);
+		break;
 	case 1:
 	case 2:
 		break;