Message ID | 1429186666-20547-1-git-send-email-weiyj_lk@163.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 427ced4b203dfea4f08b1298cd1f88e19039fca4 |
Headers | show |
Wei Yongjun wrote: > In case of error, the function devm_kzalloc() returns NULL not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced with NULL > test. Acked-by: Peter Rosin <peda@axentia.se> Thanks, Peter
On Thu, Apr 16, 2015 at 08:17:46PM +0800, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > In case of error, the function devm_kzalloc() returns NULL > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. Applied, thanks.
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 16f1b71..aab0af6 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc/codecs/tfa9879.c @@ -280,8 +280,8 @@ static int tfa9879_i2c_probe(struct i2c_client *i2c, int i; tfa9879 = devm_kzalloc(&i2c->dev, sizeof(*tfa9879), GFP_KERNEL); - if (IS_ERR(tfa9879)) - return PTR_ERR(tfa9879); + if (!tfa9879) + return -ENOMEM; i2c_set_clientdata(i2c, tfa9879);