diff mbox

[v2,2/2] mfd: arizona: Update DT binding to support hpdet channel

Message ID 1429589505-11954-3-git-send-email-ideal.song@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Inha Song April 21, 2015, 4:11 a.m. UTC
This patch add device tree bindings for the pdata needed to configure
the Accessory Detect Mode select when Headphone detection.

Signed-off-by: Inha Song <ideal.song@samsung.com>
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Lee Jones April 29, 2015, 10:57 a.m. UTC | #1
Does this looks okay to you Charles?

> This patch add device tree bindings for the pdata needed to configure
> the Accessory Detect Mode select when Headphone detection.

Isn't the idea of headphone detection that it headphones are detected
i.e. automatically?

> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 7bd1273..3529592 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -49,6 +49,12 @@ Optional properties:
>      input singals. If values less than the number of input signals, elements
>      that has not been specifed are set to 0 by default.
>  
> +  - wlf,hpdet-channel : Headphone detection channel.
> +	1 or ARIZONA_ACCDET_MODE_HPL - Headphone detect mode is set to HPDETL
> +	2 or ARIZONA_ACCDET_MODE_HPR - Headphone detect mode is set to HPDETR
> +	If this node is not mentioned or if the value is unknown, then
> +	headphone detection mode is set to MICDET.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt
Charles Keepax April 29, 2015, 1:12 p.m. UTC | #2
On Wed, Apr 29, 2015 at 11:57:37AM +0100, Lee Jones wrote:
> Does this looks okay to you Charles?
> 
> > This patch add device tree bindings for the pdata needed to configure
> > the Accessory Detect Mode select when Headphone detection.
> 
> Isn't the idea of headphone detection that it headphones are detected
> i.e. automatically?
> 

Yeah, pretty much the chip can run an impedance measurement on
either the left or the right headphone pin and to complicate
things a little further you don't necessarily have to wire that
to the actual headphones in hardware. So people tend to wire
up all sorts of odd things that they thought sounded awesome. So
you do really need a way to inform the driver which pin is
actually going to be useful for measuring the headphone impedance
on a specific system.

In an ideal world we would just measure both and take the
average, but in practice it is very dependent on how the hardware
is wired up.

Thanks,
Charles
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 7bd1273..3529592 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -49,6 +49,12 @@  Optional properties:
     input singals. If values less than the number of input signals, elements
     that has not been specifed are set to 0 by default.
 
+  - wlf,hpdet-channel : Headphone detection channel.
+	1 or ARIZONA_ACCDET_MODE_HPL - Headphone detect mode is set to HPDETL
+	2 or ARIZONA_ACCDET_MODE_HPR - Headphone detect mode is set to HPDETR
+	If this node is not mentioned or if the value is unknown, then
+	headphone detection mode is set to MICDET.
+
   - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
     they are being externally supplied. As covered in
     Documentation/devicetree/bindings/regulator/regulator.txt