diff mbox

[1/2] sound: Close holes in struct snd_pcm_hw_rule

Message ID 1430130030-17895-1-git-send-email-lars@metafoo.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lars-Peter Clausen April 27, 2015, 10:20 a.m. UTC
On a 64-bit system there are two 32-bit holes due to the alignment of 64-bit
fields. Reordering things slightly gets rid of those holes, reducing the
size of the struct by 17% percent of its original size.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 include/sound/pcm.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Takashi Iwai April 27, 2015, 10:27 a.m. UTC | #1
At Mon, 27 Apr 2015 12:20:28 +0200,
Lars-Peter Clausen wrote:
> 
> On a 64-bit system there are two 32-bit holes due to the alignment of 64-bit
> fields. Reordering things slightly gets rid of those holes, reducing the
> size of the struct by 17% percent of its original size.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks, applied.


Takashi

> ---
>  include/sound/pcm.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> index 0cb7f3f..d632809 100644
> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -224,9 +224,10 @@ typedef int (*snd_pcm_hw_rule_func_t)(struct snd_pcm_hw_params *params,
>  
>  struct snd_pcm_hw_rule {
>  	unsigned int cond;
> -	snd_pcm_hw_rule_func_t func;
>  	int var;
>  	int deps[4];
> +
> +	snd_pcm_hw_rule_func_t func;
>  	void *private;
>  };
>  
> -- 
> 1.8.0
>
diff mbox

Patch

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 0cb7f3f..d632809 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -224,9 +224,10 @@  typedef int (*snd_pcm_hw_rule_func_t)(struct snd_pcm_hw_params *params,
 
 struct snd_pcm_hw_rule {
 	unsigned int cond;
-	snd_pcm_hw_rule_func_t func;
 	int var;
 	int deps[4];
+
+	snd_pcm_hw_rule_func_t func;
 	void *private;
 };