From patchwork Fri May 8 02:24:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6362111 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 90292BEEE1 for ; Fri, 8 May 2015 02:25:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BAB132015A for ; Fri, 8 May 2015 02:25:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 9082C200B4 for ; Fri, 8 May 2015 02:24:59 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 77C212651A3; Fri, 8 May 2015 04:24:58 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id F35B9261292; Fri, 8 May 2015 04:24:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6E47D2612D2; Fri, 8 May 2015 04:24:49 +0200 (CEST) Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com [209.85.160.176]) by alsa0.perex.cz (Postfix) with ESMTP id 3DD9D2610A6 for ; Fri, 8 May 2015 04:24:42 +0200 (CEST) Received: by ykft189 with SMTP id t189so16795567ykf.1 for ; Thu, 07 May 2015 19:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=mi4p2Lb7ZmIiWFXJF2PyRQq+XMzLXPugmZwqY8uTOf4=; b=W3rrsIH+jf/kcNawC0mJBzeMukiNmtJkeUGDAk2T0VP+zZJl+qGvXxs3u0BYAg8lDw WKyjaJY2TIPwlTe4msy30e7KGOXhGj7FwVJDhVJA4oTaavBg4yCjWjyJg1falF/IAZ0T 0YWyijmh1LKyQaOYFRUXHATrsdfby6SiK5vm0hfXjY2zuRQkyDYhyzSLTJXwIX5n18ru vLNkuE420nO3fbyEKScpPy0oS41C6ah+jtLx82syF27GWLgL2gkk3OmChcHSwaZmRQGO KLng0cqukTXBAwilLol2NeCTmX47thOdDp077AfPTtM4Vp3CnXlK6uZkhRX1gP1ePG/F 1yYA== X-Received: by 10.236.2.97 with SMTP id 61mr1303745yhe.195.1431051880973; Thu, 07 May 2015 19:24:40 -0700 (PDT) Received: from localhost.localdomain ([187.64.235.17]) by mx.google.com with ESMTPSA id e94sm3369291yhq.44.2015.05.07.19.24.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 May 2015 19:24:39 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Date: Thu, 7 May 2015 23:24:16 -0300 Message-Id: <1431051856-22476-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: nicoleotsuka@gmail.com, Fabio Estevam , alsa-devel@alsa-project.org, timur@tabi.org Subject: [alsa-devel] [PATCH] ASoC: fsl_ssi: No need call of_device_is_available() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam The comment and the call to of_device_is_available() are not really needed. It is the expected behaviour to probe only the ssi nodes that are enabled in the device tree. Signed-off-by: Fabio Estevam Acked-by: Timur Tabi --- sound/soc/fsl/fsl_ssi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 0d48804..c7647e0 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1292,13 +1292,6 @@ static int fsl_ssi_probe(struct platform_device *pdev) void __iomem *iomem; char name[64]; - /* SSIs that are not connected on the board should have a - * status = "disabled" - * property in their device tree nodes. - */ - if (!of_device_is_available(np)) - return -ENODEV; - of_id = of_match_device(fsl_ssi_ids, &pdev->dev); if (!of_id || !of_id->data) return -EINVAL;