From patchwork Thu Jun 4 14:13:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Girdwood X-Patchwork-Id: 6547521 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 254BD9F326 for ; Thu, 4 Jun 2015 14:13:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3BB3F2078C for ; Thu, 4 Jun 2015 14:13:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 0545120794 for ; Thu, 4 Jun 2015 14:13:42 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id CBD712607F7; Thu, 4 Jun 2015 16:13:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id BE0FE260661; Thu, 4 Jun 2015 16:13:32 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0832F26069C; Thu, 4 Jun 2015 16:13:32 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id 368F326061E for ; Thu, 4 Jun 2015 16:13:19 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 04 Jun 2015 07:13:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="740936502" Received: from lund-mobl1.ger.corp.intel.com (HELO [10.252.29.67]) ([10.252.29.67]) by orsmga002.jf.intel.com with ESMTP; 04 Jun 2015 07:13:18 -0700 Message-ID: <1433427189.19747.53.camel@loki> From: Liam Girdwood To: Mark Brown Date: Thu, 04 Jun 2015 15:13:09 +0100 In-Reply-To: <20150604120418.GE14071@sirena.org.uk> References: <201506041837.OFTVnhYj%fengguang.wu@intel.com> <20150604120418.GE14071@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: alsa-devel@alsa-project.org, kbuild test robot , kbuild-all@01.org Subject: Re: [alsa-devel] [asoc:topic/topology 104/105] :undefined reference to `snd_soc_dapm_new_control' X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2015-06-04 at 13:04 +0100, Mark Brown wrote: > On Thu, Jun 04, 2015 at 06:58:38PM +0800, kbuild test robot wrote: > > > All error/warnings (new ones prefixed by >>): > > > > sound/built-in.o: In function `soc_tplg_dapm_widget_create': > > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control' > > The fix for the build bug in your patch exporting this was to add a > static prototype (you were in the CC for that fix) so now the topology > code still doesn't have the export. > > Can you send a fixup please? Sorry, appended below. I can resend separately if required. From 3df449a45fcde9f63dd34683d4216a73bd900f98 Mon Sep 17 00:00:00 2001 From: Liam Girdwood Date: Thu, 4 Jun 2015 15:08:34 +0100 Subject: [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol Fix the following error:- All error/warnings (new ones prefixed by >>): > > sound/built-in.o: In function `soc_tplg_dapm_widget_create': > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control' Signed-off-by: Liam Girdwood --- sound/soc/soc-dapm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 92d57a9..1b4a6eb 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -53,7 +53,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm, int (*connected)(struct snd_soc_dapm_widget *source, struct snd_soc_dapm_widget *sink)); -static struct snd_soc_dapm_widget * +struct snd_soc_dapm_widget * snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, const struct snd_soc_dapm_widget *widget); @@ -3270,7 +3270,7 @@ int snd_soc_dapm_put_pin_switch(struct snd_kcontrol *kcontrol, } EXPORT_SYMBOL_GPL(snd_soc_dapm_put_pin_switch); -static struct snd_soc_dapm_widget * +struct snd_soc_dapm_widget * snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, const struct snd_soc_dapm_widget *widget) {