diff mbox

[v6,3/4] ASoC: Intel - add makefile support for SKL driver

Message ID 1434546055-28866-4-git-send-email-vinod.koul@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vinod Koul June 17, 2015, 1 p.m. UTC 
From: Jeeja KP <jeeja.kp@intel.com>

This adds makefile and Kconfig to enable Skylake HD audio PCM driver

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/Kconfig          | 7 +++++++
 sound/soc/intel/Makefile         | 1 +
 sound/soc/intel/skylake/Makefile | 3 +++
 3 files changed, 11 insertions(+)
 create mode 100644 sound/soc/intel/skylake/Makefile

Comments

Mark Brown June 19, 2015, 3:27 p.m. UTC | #1 
On Wed, Jun 17, 2015 at 06:30:54PM +0530, Vinod Koul wrote:

> +config SND_SOC_INTEL_SKYLAKE
> +	tristate
> +	select SND_HDA_EXT_CORE

Should this be _SKYLAKE_HDA or something?  I may be confused on product
naming and terminology but I thought these processors had both HDA and
non-HDA support (possibly in the same silicon at times)?
Vinod Koul June 19, 2015, 4:48 p.m. UTC | #2 
On Fri, Jun 19, 2015 at 04:27:48PM +0100, Mark Brown wrote:
> On Wed, Jun 17, 2015 at 06:30:54PM +0530, Vinod Koul wrote:
> 
> > +config SND_SOC_INTEL_SKYLAKE
> > +	tristate
> > +	select SND_HDA_EXT_CORE
> 
> Should this be _SKYLAKE_HDA or something?  I may be confused on product
> naming and terminology but I thought these processors had both HDA and
> non-HDA support (possibly in the same silicon at times)?
Hi Mark,

Unlike haswell or previous controllers, we dont have a separate HDA only
controller and a separate I2S based controller, it is integrated now :)

So there will be only one Skylake controller :)

Thanks
Mark Brown June 20, 2015, 9:15 a.m. UTC | #3 
On Fri, Jun 19, 2015 at 10:18:24PM +0530, Vinod Koul wrote:
> On Fri, Jun 19, 2015 at 04:27:48PM +0100, Mark Brown wrote:

> > Should this be _SKYLAKE_HDA or something?  I may be confused on product
> > naming and terminology but I thought these processors had both HDA and
> > non-HDA support (possibly in the same silicon at times)?

> Unlike haswell or previous controllers, we dont have a separate HDA only
> controller and a separate I2S based controller, it is integrated now :)

> So there will be only one Skylake controller :)

But this is specifically the HDA bits - I'd expect that there will be
systems where people want Sky Lake support but don't need the HDA bits
(possibly some of these more memory constrained ones)?
Vinod Koul June 22, 2015, 5:33 a.m. UTC | #4 
On Sat, Jun 20, 2015 at 10:15:35AM +0100, Mark Brown wrote:
> On Fri, Jun 19, 2015 at 10:18:24PM +0530, Vinod Koul wrote:
> > On Fri, Jun 19, 2015 at 04:27:48PM +0100, Mark Brown wrote:
> 
> > > Should this be _SKYLAKE_HDA or something?  I may be confused on product
> > > naming and terminology but I thought these processors had both HDA and
> > > non-HDA support (possibly in the same silicon at times)?
> 
> > Unlike haswell or previous controllers, we dont have a separate HDA only
> > controller and a separate I2S based controller, it is integrated now :)
> 
> > So there will be only one Skylake controller :)
> 
> But this is specifically the HDA bits - I'd expect that there will be
> systems where people want Sky Lake support but don't need the HDA bits
> (possibly some of these more memory constrained ones)?
Nope, starting with SKL that is not possible. You get SKL HDA controller as
interface to subsystem. The BE can be either HDA (legacy/or with aDSP) or
I2S etc, but interface to subsystem is the HDA controller.

Thanks
diff mbox

Patch

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index f3060a4ca040..9fa24c7003e5 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -132,3 +132,10 @@  config SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH
       This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell
       platforms with MAX98090 audio codec it also can support TI jack chip as aux device.
       If unsure select "N".
+
+config SND_SOC_INTEL_SKYLAKE
+	tristate
+	select SND_HDA_EXT_CORE
+	help
+	  Say Y here to include support for ASoC Intel "High Definition
+	  Audio" (Skylake) and its compatible devices.
diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
index 3853ec2ddbc7..2972699e1435 100644
--- a/sound/soc/intel/Makefile
+++ b/sound/soc/intel/Makefile
@@ -5,6 +5,7 @@  obj-$(CONFIG_SND_SOC_INTEL_SST) += common/
 obj-$(CONFIG_SND_SOC_INTEL_HASWELL) += haswell/
 obj-$(CONFIG_SND_SOC_INTEL_BAYTRAIL) += baytrail/
 obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += atom/
+obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/
 
 # Machine support
 obj-$(CONFIG_SND_SOC_INTEL_SST) += boards/
diff --git a/sound/soc/intel/skylake/Makefile b/sound/soc/intel/skylake/Makefile
new file mode 100644
index 000000000000..734d17cafde7
--- /dev/null
+++ b/sound/soc/intel/skylake/Makefile
@@ -0,0 +1,3 @@ 
+snd-soc-skl-objs := skl.o skl-pcm.o
+
+obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl.o