| Message ID | 1435843741.17967.3.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ca94085139d4874701af4f149bebfb05e105b245 |
| Headers | show |
On Thu, Jul 02, 2015 at 09:29:01PM +0800, Axel Lin wrote:
> This reverts ed043aebe6ec ("ASoC: wm8996: Pass the IRQF_ONESHOT flag").
Please use subject lines reflecting the style for the subsystem, even
for reverts.
2015-07-09 2:34 GMT+08:00 Mark Brown <broonie@kernel.org>: > On Thu, Jul 02, 2015 at 09:29:01PM +0800, Axel Lin wrote: >> This reverts ed043aebe6ec ("ASoC: wm8996: Pass the IRQF_ONESHOT flag"). > > Please use subject lines reflecting the style for the subsystem, even > for reverts. I don't get it. I thought if a patch is actually a revert, it should look like a revert. So I generate the patch by "git revert". Is that wrong?
On Thu, Jul 09, 2015 at 09:52:23AM +0800, Axel Lin wrote: > 2015-07-09 2:34 GMT+08:00 Mark Brown <broonie@kernel.org>: > > On Thu, Jul 02, 2015 at 09:29:01PM +0800, Axel Lin wrote: > >> This reverts ed043aebe6ec ("ASoC: wm8996: Pass the IRQF_ONESHOT flag"). > > Please use subject lines reflecting the style for the subsystem, even > > for reverts. > I don't get it. > I thought if a patch is actually a revert, it should look like a revert. > So I generate the patch by "git revert". Is that wrong? You should edit the default subject line to be a normal subject line. Reverts are patches like any other.
diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 3dd063f..370459f 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2647,12 +2647,10 @@ static int wm8996_probe(struct snd_soc_codec *codec) if (irq_flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) ret = request_threaded_irq(i2c->irq, NULL, wm8996_edge_irq, - irq_flags | IRQF_ONESHOT, - "wm8996", codec); + irq_flags, "wm8996", codec); else ret = request_threaded_irq(i2c->irq, NULL, wm8996_irq, - irq_flags | IRQF_ONESHOT, - "wm8996", codec); + irq_flags, "wm8996", codec); if (ret == 0) { /* Unmask the interrupt */
This reverts ed043aebe6ec ("ASoC: wm8996: Pass the IRQF_ONESHOT flag"). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;". Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/wm8996.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)