diff mbox

[v2,1/3] ALSA: hdac: Fix size allocation for ext device allocation

Message ID 1440310971-14849-1-git-send-email-vinod.koul@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vinod Koul Aug. 23, 2015, 6:22 a.m. UTC
While creating hdac_ext_device, we used hdev for sizeof insteadof
edev, which resulted in eventual crash of the system Fix the size
here

Fixes: a512f5611646 ('ALSA: hdac: add hdac extended device')
Reported-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/hda/ext/hdac_ext_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Aug. 23, 2015, 7:44 a.m. UTC | #1
On Sun, 23 Aug 2015 08:22:49 +0200,
Vinod Koul wrote:
> 
> While creating hdac_ext_device, we used hdev for sizeof insteadof
> edev, which resulted in eventual crash of the system Fix the size
> here
> 
> Fixes: a512f5611646 ('ALSA: hdac: add hdac extended device')
> Reported-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Applied all three patches.


thanks,

Takashi

> ---
>  sound/hda/ext/hdac_ext_bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c
> index 8544e4fb1cd3..4449d1a99089 100644
> --- a/sound/hda/ext/hdac_ext_bus.c
> +++ b/sound/hda/ext/hdac_ext_bus.c
> @@ -139,7 +139,7 @@ int snd_hdac_ext_bus_device_init(struct hdac_ext_bus *ebus, int addr)
>  	char name[15];
>  	int ret;
>  
> -	edev = kzalloc(sizeof(*hdev), GFP_KERNEL);
> +	edev = kzalloc(sizeof(*edev), GFP_KERNEL);
>  	if (!edev)
>  		return -ENOMEM;
>  	hdev = &edev->hdac;
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c
index 8544e4fb1cd3..4449d1a99089 100644
--- a/sound/hda/ext/hdac_ext_bus.c
+++ b/sound/hda/ext/hdac_ext_bus.c
@@ -139,7 +139,7 @@  int snd_hdac_ext_bus_device_init(struct hdac_ext_bus *ebus, int addr)
 	char name[15];
 	int ret;
 
-	edev = kzalloc(sizeof(*hdev), GFP_KERNEL);
+	edev = kzalloc(sizeof(*edev), GFP_KERNEL);
 	if (!edev)
 		return -ENOMEM;
 	hdev = &edev->hdac;