| Message ID | 1442843834-4648-4-git-send-email-bywxiaobai@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote: > > > -static inline int prioq_match(struct snd_seq_event_cell *cell, > > +static inline bool prioq_match(struct snd_seq_event_cell *cell, > > int client, int timestamp) > > I think you should fix up the indentation now. Sorry, I'm quite a new guy to linux kernel. I think you mean this patch is not appropriate, right? > > johannes
On Tue, Sep 22, 2015 at 03:28:12PM +0200, Johannes Berg wrote: > On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote: > > On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote: > > > > > > > -static inline int prioq_match(struct snd_seq_event_cell *cell, > > > > +static inline bool prioq_match(struct snd_seq_event_cell *cell, > > > > int client, int timestamp) > > > > > > I think you should fix up the indentation now. > > > > Sorry, I'm quite a new guy to linux kernel. I think you mean this > > patch is not appropriate, right? > > > > No, the change itself is fine, but you should fix the indentation there > so it lines up properly after your change. OK, will send it ASAP. Thanks. > > johannes
diff --git a/sound/core/seq/seq_prioq.c b/sound/core/seq/seq_prioq.c index bc1c848..aebae09 100644 --- a/sound/core/seq/seq_prioq.c +++ b/sound/core/seq/seq_prioq.c @@ -264,26 +264,26 @@ struct snd_seq_event_cell *snd_seq_prioq_cell_peek(struct snd_seq_prioq * f) } -static inline int prioq_match(struct snd_seq_event_cell *cell, +static inline bool prioq_match(struct snd_seq_event_cell *cell, int client, int timestamp) { if (cell->event.source.client == client || cell->event.dest.client == client) - return 1; + return true; if (!timestamp) - return 0; + return false; switch (cell->event.flags & SNDRV_SEQ_TIME_STAMP_MASK) { case SNDRV_SEQ_TIME_STAMP_TICK: if (cell->event.time.tick) - return 1; + return true; break; case SNDRV_SEQ_TIME_STAMP_REAL: if (cell->event.time.time.tv_sec || cell->event.time.time.tv_nsec) - return 1; + return true; break; } - return 0; + return false; } /* remove cells for left client */
This patch makes prioq_match return bool due to this particular function only using either one or zero as its return value. No functional change. Signed-off-by: Yaowei Bai <bywxiaobai@163.com> --- sound/core/seq/seq_prioq.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)