diff mbox

ASoC: ad193x-spi: Fixup ad193x_spi_id table

Message ID 1444123596.7405.2.camel@ingics.com (mailing list archive)
State Accepted
Commit d46183efe3b57d06461c9bea35e1a0262391fe77
Headers show

Commit Message

Axel Lin Oct. 6, 2015, 9:26 a.m. UTC
AD1939 is missed from the table, so add it.
AD1936 and AD1937 are controlled by I2C interface, so remove them.

Fixes: e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/ad193x-spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Lars-Peter Clausen Oct. 6, 2015, 4:26 p.m. UTC | #1
On 10/06/2015 11:26 AM, Axel Lin wrote:
> AD1939 is missed from the table, so add it.
> AD1936 and AD1937 are controlled by I2C interface, so remove them.
> 
> Fixes: e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Thanks for catching that.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
>  sound/soc/codecs/ad193x-spi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/ad193x-spi.c b/sound/soc/codecs/ad193x-spi.c
> index 364e8211..b55055a 100644
> --- a/sound/soc/codecs/ad193x-spi.c
> +++ b/sound/soc/codecs/ad193x-spi.c
> @@ -39,9 +39,8 @@ static const struct spi_device_id ad193x_spi_id[] = {
>  	{ "ad193x", AD193X },
>  	{ "ad1933", AD1933 },
>  	{ "ad1934", AD1934 },
> -	{ "ad1936", AD193X },
> -	{ "ad1937", AD193X },
>  	{ "ad1938", AD193X },
> +	{ "ad1939", AD193X },

The adau1328 is actually also support by this driver, though I had send a
patch for this a while ago, but I guess I didn't. But we can add that later
in a separate patch.

>  	{ }
>  };
>  MODULE_DEVICE_TABLE(spi, ad193x_spi_id);
>
diff mbox

Patch

diff --git a/sound/soc/codecs/ad193x-spi.c b/sound/soc/codecs/ad193x-spi.c
index 364e8211..b55055a 100644
--- a/sound/soc/codecs/ad193x-spi.c
+++ b/sound/soc/codecs/ad193x-spi.c
@@ -39,9 +39,8 @@  static const struct spi_device_id ad193x_spi_id[] = {
 	{ "ad193x", AD193X },
 	{ "ad1933", AD1933 },
 	{ "ad1934", AD1934 },
-	{ "ad1936", AD193X },
-	{ "ad1937", AD193X },
 	{ "ad1938", AD193X },
+	{ "ad1939", AD193X },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad193x_spi_id);