| Message ID | 1445830900-1752-1-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7c45e3cc6a59fb00edea65dfb6d3ae60403e4539 |
| Headers | show |
On Mon, 2015-10-26 at 12:41 +0900, Mark Brown wrote: > We had inserted a #error into the topology UAPI code to ensure that the > ABI was not adopted by userspace while final review and testing was > ongoing. Since we are now comfortable that the ABI is suitable for > production remove the #error, future changes will include provision for > backwards compatibility. > > Signed-off-by: Mark Brown <broonie@kernel.org> Acked-by: Vinod Koul <vinod.koul@intel.com> I don't have any local patches on topology core, so am okay with this. Liam, Mengdong do we have any more patches looking to be merged? I do see we have the series we required in topic/topology, but is anything left out?
On Mon, 26 Oct 2015 04:41:40 +0100, Mark Brown wrote: > > We had inserted a #error into the topology UAPI code to ensure that the > ABI was not adopted by userspace while final review and testing was > ongoing. Since we are now comfortable that the ABI is suitable for > production remove the #error, future changes will include provision for > backwards compatibility. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > > Are we OK with this? Looking for some acks and reviews... Don't forget to add this entry to include/uapi/sound/Makefile. Otherwise it's useless... Takashi > include/uapi/sound/asoc.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h > index 247c50b..51b8066 100644 > --- a/include/uapi/sound/asoc.h > +++ b/include/uapi/sound/asoc.h > @@ -18,12 +18,6 @@ > #include <linux/types.h> > #include <sound/asound.h> > > -#ifndef __KERNEL__ > -#error This API is an early revision and not enabled in the current > -#error kernel release, it will be enabled in a future kernel version > -#error with incompatible changes to what is here. > -#endif > - > /* > * Maximum number of channels topology kcontrol can represent. > */ > -- > 2.6.1 >
On Mon, Oct 26, 2015 at 08:30:55AM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > Are we OK with this? Looking for some acks and reviews... > Don't forget to add this entry to include/uapi/sound/Makefile. > Otherwise it's useless... Ugh, well it's always been useless then :(
On Mon, Oct 26, 2015 at 12:41:40PM +0900, Mark Brown wrote: > We had inserted a #error into the topology UAPI code to ensure that the > ABI was not adopted by userspace while final review and testing was > ongoing. Since we are now comfortable that the ABI is suitable for > production remove the #error, future changes will include provision for > backwards compatibility. > Are we OK with this? Looking for some acks and reviews... I saw a reply from Vinod but nobody else here.
On Sat, 2015-10-31 at 11:54 +0900, Mark Brown wrote: > On Mon, Oct 26, 2015 at 12:41:40PM +0900, Mark Brown wrote: > > We had inserted a #error into the topology UAPI code to ensure that the > > ABI was not adopted by userspace while final review and testing was > > ongoing. Since we are now comfortable that the ABI is suitable for > > production remove the #error, future changes will include provision for > > backwards compatibility. > > > Are we OK with this? Looking for some acks and reviews... > > I saw a reply from Vinod but nobody else here. Mengdong are we good here ? Liam
diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index 247c50b..51b8066 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -18,12 +18,6 @@ #include <linux/types.h> #include <sound/asound.h> -#ifndef __KERNEL__ -#error This API is an early revision and not enabled in the current -#error kernel release, it will be enabled in a future kernel version -#error with incompatible changes to what is here. -#endif - /* * Maximum number of channels topology kcontrol can represent. */
We had inserted a #error into the topology UAPI code to ensure that the ABI was not adopted by userspace while final review and testing was ongoing. Since we are now comfortable that the ABI is suitable for production remove the #error, future changes will include provision for backwards compatibility. Signed-off-by: Mark Brown <broonie@kernel.org> --- Are we OK with this? Looking for some acks and reviews... include/uapi/sound/asoc.h | 6 ------ 1 file changed, 6 deletions(-)