From patchwork Sun Nov 1 19:53:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 7532641 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 48FC9BEEA4 for ; Sun, 1 Nov 2015 19:53:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72EBB20656 for ; Sun, 1 Nov 2015 19:53:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id EFE1820651 for ; Sun, 1 Nov 2015 19:53:43 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2CC9B2605B4; Sun, 1 Nov 2015 20:53:42 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0BC72260523; Sun, 1 Nov 2015 20:53:34 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2120A26057A; Sun, 1 Nov 2015 20:53:33 +0100 (CET) Received: from gsystem.sk (ns.gsystem.sk [62.176.172.50]) by alsa0.perex.cz (Postfix) with ESMTP id 1BBB9260513 for ; Sun, 1 Nov 2015 20:53:26 +0100 (CET) Received: from stip-static-68.213-81-217.telecom.sk ([213.81.217.68] helo=gsql.ggedos.sk) by gsystem.sk with esmtpsa (TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Zsygu-0004Ar-Ja; Sun, 01 Nov 2015 20:53:24 +0100 From: Ondrej Zary To: alsa-devel@alsa-project.org Date: Sun, 1 Nov 2015 20:53:14 +0100 Message-Id: <1446407594-2382-1-git-send-email-linux@rainbow-software.org> X-Mailer: git-send-email 1.7.10.4 Cc: Takashi Iwai , Kernel development list Subject: [alsa-devel] [PATCH] snd-maestro3: Fix Allegro mute until master volume/mute is touched X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP ESS Allegro (marked ES1989S), [125d:1988] (rev 10) is mute after loading snd-maestro3 and running alsactl restore. Touching master volume or mute makes it work. Looks like a bug in the AC'97 codec integrated into the chip. Write AC97_MASTER register twice to work-around the problem. Signed-off-by: Ondrej Zary --- sound/pci/maestro3.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c index 965d5c6..17ae926 100644 --- a/sound/pci/maestro3.c +++ b/sound/pci/maestro3.c @@ -1929,6 +1929,16 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val) return; snd_m3_outw(chip, val, CODEC_DATA); snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + /* + * Workaround for buggy ES1988 integrated AC'97 codec. It remains silent + * until the MASTER volume or mute is touched (alsactl restore does not + * work). + */ + if (ac97->id == 0x45838308 && reg == AC97_MASTER) { + snd_m3_ac97_wait(chip); + snd_m3_outw(chip, val, CODEC_DATA); + snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + } }