From patchwork Fri Nov 6 14:57:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Girdwood X-Patchwork-Id: 7569491 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 196CE9F2F7 for ; Fri, 6 Nov 2015 14:58:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4201F206ED for ; Fri, 6 Nov 2015 14:58:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 625E6206E4 for ; Fri, 6 Nov 2015 14:58:04 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id ECA3C260622; Fri, 6 Nov 2015 15:58:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 6A3D62604A1; Fri, 6 Nov 2015 15:57:55 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3BEC92604E2; Fri, 6 Nov 2015 15:57:54 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by alsa0.perex.cz (Postfix) with ESMTP id E17A3260438 for ; Fri, 6 Nov 2015 15:57:46 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 06 Nov 2015 06:57:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,252,1444719600"; d="scan'208";a="829219168" Received: from mikkelss-mobl2.ger.corp.intel.com (HELO [10.252.24.70]) ([10.252.24.70]) by fmsmga001.fm.intel.com with ESMTP; 06 Nov 2015 06:57:19 -0800 Message-ID: <1446821837.2776.27.camel@loki> From: Liam Girdwood To: Takashi Iwai Date: Fri, 06 Nov 2015 14:57:17 +0000 In-Reply-To: References: <1446813576-29295-1-git-send-email-mengdong.lin@linux.intel.com> <20151106133118.GA18120@localhost> <1446820647.2776.19.camel@loki> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com, Vinod Koul , mengdong.lin@intel.com, broonie@kernel.org, subhransu.s.prusty@intel.com Subject: Re: [alsa-devel] [PATCH] topology: Include in API header file X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: > On Fri, 06 Nov 2015 15:37:27 +0100, > Liam Girdwood wrote: > > > > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > > From: Liam Girdwood > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > Use a generic unsigned long long for formats instead of an ABI endian > > specific __le64 type. > > Or use uint64_t instead. This is the standard definition of 64bit > integer. I thought we already include stdint.h somewhere, but you can > included it there again to be sure, too. > I didn't see stdint.h so used unsigned long long on the first patch. The patch below fixes this though :- From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 From: Liam Girdwood Date: Fri, 6 Nov 2015 14:30:36 +0000 Subject: [PATCH] topology: remove little endian type from userspace header. Use a generic uint64_t for formats instead of an ABI endian specific __le64 type. Signed-off-by: Liam Girdwood --- include/topology.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/topology.h b/include/topology.h index b631871..993537c 100644 --- a/include/topology.h +++ b/include/topology.h @@ -21,6 +21,8 @@ #ifndef __ALSA_TOPOLOGY_H #define __ALSA_TOPOLOGY_H +#include + #ifdef __cplusplus extern "C" { #endif @@ -665,7 +667,7 @@ struct snd_tplg_stream_template { */ struct snd_tplg_stream_caps_template { const char *name; /*!< name of the stream caps */ - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ + uint64_t formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ unsigned int rate_min; /*!< min rate */ unsigned int rate_max; /*!< max rate */