From patchwork Thu Dec 3 14:46:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Henningsson X-Patchwork-Id: 7760811 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0C9A0BEEE1 for ; Thu, 3 Dec 2015 14:47:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4AA7A20549 for ; Thu, 3 Dec 2015 14:47:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1830F20511 for ; Thu, 3 Dec 2015 14:47:15 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 29BF3260442; Thu, 3 Dec 2015 15:47:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C1F87260423; Thu, 3 Dec 2015 15:47:05 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7A879260429; Thu, 3 Dec 2015 15:47:04 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id 65E73260423 for ; Thu, 3 Dec 2015 15:46:58 +0100 (CET) Received: from c83-251-169-171.bredband.comhem.se ([83.251.169.171] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1a4V9t-0000gs-Vg; Thu, 03 Dec 2015 14:46:58 +0000 From: David Henningsson To: tiwai@suse.de, alsa-devel@alsa-project.org Date: Thu, 3 Dec 2015 15:46:57 +0100 Message-Id: <1449154017-5256-1-git-send-email-david.henningsson@canonical.com> X-Mailer: git-send-email 1.9.1 Cc: David Henningsson Subject: [alsa-devel] [PATCH] ALSA: hda - Enable power_save_node for CX20722 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I've tested it on one device and it works fine, no clicks. Signed-off-by: David Henningsson --- Alsa-info for this device is available here: https://launchpadlibrarian.net/228090406/AlsaInfo.txt Possibly it works well for other chips too, but this is the only one I have tested. Btw; I noticed another thing which I wonder whether it's correct or not: If I run "hda-emu AlsaInfo.txt", all nodes are in D3. But after running "P 0 p", some nodes (e g the internal speaker pin) stays in D0. Is that expected? I thought all pins would go down to D3 when playback closes. Same behaviour is seen on the real hardware, too. sound/pci/hda/patch_conexant.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index ef19890..6122b8c 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -901,6 +901,9 @@ static int patch_conexant_auto(struct hda_codec *codec) snd_hda_pick_fixup(codec, cxt5051_fixup_models, cxt5051_fixups, cxt_fixups); break; + case 0x14f150f2: + codec->power_save_node = 1; + /* Fall through */ default: codec->pin_amp_workaround = 1; snd_hda_pick_fixup(codec, cxt5066_fixup_models,