From patchwork Thu Dec 17 10:07:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 7873541 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9C8F89F1C2 for ; Thu, 17 Dec 2015 13:37:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D10122042A for ; Thu, 17 Dec 2015 13:37:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 4E2D720429 for ; Thu, 17 Dec 2015 13:37:27 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 76BBD260483; Thu, 17 Dec 2015 14:37:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0D9DA260537; Thu, 17 Dec 2015 14:36:38 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C4398265522; Thu, 17 Dec 2015 11:07:56 +0100 (CET) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by alsa0.perex.cz (Postfix) with ESMTP id 63348265715 for ; Thu, 17 Dec 2015 11:07:28 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l126so13771675wml.0 for ; Thu, 17 Dec 2015 02:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=zWfzJsl0yTg+zpU9b2p6wGuv0RVg+huyoLhf/z6ka2w=; b=AFo7grGL5YI0ghuKvk9tOg/eh49nSttsSJpk7ZzSmS+cLfN49oE6tZdqpQMLHrdwPf b30TxCgW1EhVPGm0U8kudyOBcQWfOna3hvVqVPfTv3bpol1kSkkhH+JlF+E0sMWh6YnU CCfIfwskncXx82lPWRwZ0Tx2ZnunDI2UrXwXrUn1QJRSecwg7IDwvPjlGbOv7do1WVrR cI4CnSR8dL9M0DCy3kTRq3LDMIWAR7VxJIGXLsoXk181g4/9NVhh5ccJsEyTSFqtxc+e gze10au5nOlwyXuIt8v9S4heHww1oTIayxRZ9/7SUn35FTAhWiEYPO+sMdxy6bOI4fAA 9+Gw== X-Received: by 10.194.206.69 with SMTP id lm5mr35431303wjc.84.1450346848093; Thu, 17 Dec 2015 02:07:28 -0800 (PST) Received: from localhost.vodalys.lan (LMontsouris-657-1-109-180.w80-15.abo.wanadoo.fr. [80.15.95.180]) by smtp.gmail.com with ESMTPSA id da10sm9707738wjb.22.2015.12.17.02.07.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Dec 2015 02:07:27 -0800 (PST) From: Jean-Michel Hautbois X-Google-Original-From: Jean-Michel Hautbois To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Thu, 17 Dec 2015 11:07:23 +0100 Message-Id: <1450346843-6700-1-git-send-email-jean-michel.hautbois@veo-labs.com> X-Mailer: git-send-email 2.6.4 X-Mailman-Approved-At: Thu, 17 Dec 2015 14:36:36 +0100 Cc: lars@metafoo.de, lgirdwood@gmail.com, eric.nelson@boundarydevices.com, tiwai@suse.com, gianlucarenzi@eurekelettronica.it, broonie@kernel.org, fbrozovic@gmail.com, Jean-Michel Hautbois , alexander.stein@systec-electronic.com Subject: [alsa-devel] [PATCH] ASoC: sgtl5000: fix VAG power up timing X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP When power up, a "pop" is heard on line-in and mic-in. An analysis of the PCM shows it lasts ~400ms and looks like a filter response. VAG power up should be delayed by 400ms as VAG power down is. Signed-off-by: Jean-Michel Hautbois --- sound/soc/codecs/sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index f540f82..08b4046 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -189,6 +189,7 @@ static int power_vag_event(struct snd_soc_dapm_widget *w, case SND_SOC_DAPM_POST_PMU: snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_VAG_POWERUP, SGTL5000_VAG_POWERUP); + msleep(400); break; case SND_SOC_DAPM_PRE_PMD: