| Message ID | 1451773436-25518-1-git-send-email-minipli@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e2973769372a3de1c20249206db5ee93287a2230 |
| Headers | show |
On Sat, Jan 02, 2016 at 11:23:56PM +0100, Mathias Krause wrote: > Constify the ACPI device ID array, no need to have it writable at > runtime. Also drop the unused RT5645_INIT_REG_LEN define. Please don't mix multiple unrelated changes in a single patch, especially when there's no content overlap at all :(
On 4 January 2016 at 02:32, Mark Brown <broonie@kernel.org> wrote: > On Sat, Jan 02, 2016 at 11:23:56PM +0100, Mathias Krause wrote: >> Constify the ACPI device ID array, no need to have it writable at >> runtime. Also drop the unused RT5645_INIT_REG_LEN define. > > Please don't mix multiple unrelated changes in a single patch, > especially when there's no content overlap at all :( I've seen you've applied the patch nonetheless. So I guess you don't want me to split the patch any more? Regards, Mathias
On Wed, Jan 06, 2016 at 09:01:28AM +0100, Mathias Krause wrote: > On 4 January 2016 at 02:32, Mark Brown <broonie@kernel.org> wrote: > > Please don't mix multiple unrelated changes in a single patch, > > especially when there's no content overlap at all :( > I've seen you've applied the patch nonetheless. So I guess you don't > want me to split the patch any more? No need to split this patch but in future don't do this.
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index ef76940f9dcb..38a0b60a7f6e 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -64,7 +64,6 @@ static const struct reg_sequence init_list[] = { {RT5645_PR_BASE + 0x21, 0x4040}, {RT5645_PR_BASE + 0x23, 0x0004}, }; -#define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list) static const struct reg_sequence rt5650_init_list[] = { {0xf6, 0x0100}, @@ -3326,7 +3325,7 @@ static const struct i2c_device_id rt5645_i2c_id[] = { MODULE_DEVICE_TABLE(i2c, rt5645_i2c_id); #ifdef CONFIG_ACPI -static struct acpi_device_id rt5645_acpi_match[] = { +static const struct acpi_device_id rt5645_acpi_match[] = { { "10EC5645", 0 }, { "10EC5650", 0 }, {},
Constify the ACPI device ID array, no need to have it writable at runtime. Also drop the unused RT5645_INIT_REG_LEN define. Signed-off-by: Mathias Krause <minipli@googlemail.com> Cc: Bard Liao <bardliao@realtek.com> Cc: Oder Chiou <oder_chiou@realtek.com> Cc: John Lin <john.lin@realtek.com> --- sound/soc/codecs/rt5645.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)