From patchwork Mon Jan 25 17:07:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8112901 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4A3D2BEEE5 for ; Mon, 25 Jan 2016 17:08:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 79E88202AE for ; Mon, 25 Jan 2016 17:08:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 321052026D for ; Mon, 25 Jan 2016 17:08:52 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A00832605F2; Mon, 25 Jan 2016 18:08:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2C6B2260575; Mon, 25 Jan 2016 18:08:33 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id F263E26058E; Mon, 25 Jan 2016 18:08:31 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by alsa0.perex.cz (Postfix) with ESMTP id D4174260535 for ; Mon, 25 Jan 2016 18:08:24 +0100 (CET) Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0MHYWy-1aOr5A2nxE-003Ke6; Mon, 25 Jan 2016 18:08:08 +0100 From: Arnd Bergmann To: Mark Brown Date: Mon, 25 Jan 2016 18:07:32 +0100 Message-Id: <1453741678-1988125-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:3470HZTk+OtWHc7kuIdDIVbJZo4k/kuNrrS8jA9Mxyj3b/vlx94 npwK4aae6LpGhpUncWcf00Ddt7wOWsrx5GBPVBXXDSEcD4hc8dTFYTZ7e7pyJ1B8mvYyzkR vbXN9kw8jCmr7fgeMhIgjUlvbHNm9cEFWqBRNFxomzT41NzSTa9c6TvbR/JY2ApJcgSEZ8w l+m5KqKt0WwTWdeQ1Dl/A== X-UI-Out-Filterresults: notjunk:1; V01:K0:CKpaDW78kpA=:XzQE+wv/lQqd/px8+qks97 EQRzoB5HKAB4dMmV0VsNuxpzkOD7jVLm3TQylOy+flrMiSPcmaMQOLO+wXo8OuZasIRUZ5nDP CiDQq3/wqVhgtnmjCf8WzgbFpqFDIWmWQ75ASUEBjexodhfcYXnYe3sgM2Tf7rDg1kNT4tZX9 VW8zfTHzo+jCNRsRtIsKDmi3Sj+RrWeTIEw3MmVCVWhS7bFrS8KVjT4uyZCP5/5xXmLoTk0MK jOpzlmgO2R5jfzJS++2GLXUOUW4OcfdI0UACDsTMwAvGVrpMJshE/Ed2n8DH+KFwpcCC9aeux U9AHbJ1/oSPpr/WGRP34lsf/t4MVRLXblGcvk2pxf1AEyjuHCb6uaAga6wcjOGlwRVpiig4oe b7WLnXZ7OzDUKUDna16gnKFkEe54ClMBqJhUdvpDZXqWhRGbxAI3RVKTzFaplaGLYD+BYHIAh +LgJJB7tYq9DF+A+lLKbmrWXT3Ol2bS2fwbxGAMiqgk8SCLwWUd3SuTTx68AYZOHGUaMCW9rr M7Ba2g5x47zhOJpt1su6TvrjqglcFljrogG2X6+hRB6laLmvL9GT0Ky7VfypCmE/ty8WQfGhQ k7fi+qRdXyZjnbogVrHDpuoMpQ0N59Fqgi63Z/qUyopHl11cD4aMV6dvhwPNHtLopobpxiJgZ 8+PwYsSzl+pZD89Jbz+1jMGfEPlevGsMOeAmnQEmci2BP6iql1EMMFrSXPhruUPwwtc4= Cc: Brian Austin , Arnd Bergmann , Kuninori Morimoto , Liam Girdwood , Paul Handrigan , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH 1/2] ASoC: cs35l32: avoid uninitialized variable access X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP gcc warns about the possibilty of accessing a property read from devicetree in cs35l32_i2c_probe() when it has not been initialized because CONFIG_OF is disabled: sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe': sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] The code is actually correct because it checks the dev->of_node variable first and we know this is NULL here, but by adding a check for IS_ENABLED(CONFIG_OF), we can let the compiler know as well, and also generate smaller object code. Signed-off-by: Arnd Bergmann Signed-off-by: Arnd Bergmann > Acked-by: Brian Austin > --- sound/soc/codecs/cs35l32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 44c30fe3e315..52ffaa8eb02b 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -372,7 +372,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, dev_err(&i2c_client->dev, "could not allocate pdata\n"); return -ENOMEM; } - if (i2c_client->dev.of_node) { + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) { ret = cs35l32_handle_of_data(i2c_client, &cs35l32->pdata); if (ret != 0)