From patchwork Thu Jan 28 23:51:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Insu Yun X-Patchwork-Id: 8159771 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6200BBEEE5 for ; Fri, 29 Jan 2016 07:01:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9D6CF2037C for ; Fri, 29 Jan 2016 07:01:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 7878A201C0 for ; Fri, 29 Jan 2016 07:01:55 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A778D266AD6; Fri, 29 Jan 2016 08:01:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4B54B265FFA; Fri, 29 Jan 2016 07:41:19 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 26B86261546; Fri, 29 Jan 2016 00:49:08 +0100 (CET) Received: from mail-yk0-f171.google.com (mail-yk0-f171.google.com [209.85.160.171]) by alsa0.perex.cz (Postfix) with ESMTP id CEB892606F3 for ; Fri, 29 Jan 2016 00:49:00 +0100 (CET) Received: by mail-yk0-f171.google.com with SMTP id v14so50674142ykd.3 for ; Thu, 28 Jan 2016 15:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=TMEvllYhv5CHtpkeAABQ8B2UmXq69+D45sXHO63PuEo=; b=OcVJjsVMQK32xUyw3UaxJKALyZS07w9Z0jG7zo12kRfmP4Iz+arrBzU6vo1ylUua3H XDeSn1hijkENJIkPZ2b+U+gjvJXNP2Z8aomeYNJYp8SlrGQXqENs/vukvM87SXawJNb/ JnwutzqVnzn9JaS9hgl5aQt/r0QnKGCkSZCLuJ2TqadHlJTj87Wb8qq4YqQYJa151qjV sNMF9+Uzsa8c5LF6hNEBsY3w14PtoIyZHC0K7FcIwOL3iZOXkx0VT+yBEm/7XdMNz/B+ sCB2U5fmChE8YUDA9+D4xY9Cq4RbwXd6DJqy35b0IDMkUhwjfmViBzoWKtckw1+MLWb+ HIMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TMEvllYhv5CHtpkeAABQ8B2UmXq69+D45sXHO63PuEo=; b=hJd6eZNN8og/jiqX/6i9l5Ww42t3iGrmE/sI+uz5gY8q/Vlt6MeOqR7X8o8xpJLTXA it/roywA8MOQmUecUDlbe9dj37Ur4qdhE0blHsL4+VdtqkCtoAKOE9Gkc3HJg5fUF8Sb X8HHzRq2nv+K7qBcP2baVMmZOOgP46aFqhJohsAb0ISbMrcJPas7SUq8vsguPUrVhllQ OEhSLf5dlJfv9yViyxR6kNuQpeB3PR8oSXGWpiPLnkaeIXE1ml3dvLM3epSD6l7LeGiP kddDh29t8k1rRe+OiHU1LTRiZWLjLA7BsB/gJGQUWiRR8KETmDk41PUZUs+RMmK3BD8J 7O0A== X-Gm-Message-State: AG10YOT5BUnmlYi0kYG0e1O0HBEDOny8JKIp6hgrqIqr4U/PdPryeYGhn0blXT/gEwZ7lA== X-Received: by 10.129.82.71 with SMTP id g68mr3270589ywb.336.1454024940229; Thu, 28 Jan 2016 15:49:00 -0800 (PST) Received: from insu.gtisc.gatech.edu (insu.gtisc.gatech.edu. [143.215.130.94]) by smtp.gmail.com with ESMTPSA id i17sm416046ywc.49.2016.01.28.15.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Jan 2016 15:48:59 -0800 (PST) From: Insu Yun To: perex@perex.cz, tiwai@suse.com, michael@gernoth.net, lambert.quentin@gmail.com, pzubaj@marticonet.sk, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Thu, 28 Jan 2016 18:51:37 -0500 Message-Id: <1454025097-13153-1-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 X-Mailman-Approved-At: Fri, 29 Jan 2016 07:40:53 +0100 Cc: yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu, Insu Yun , changwoo@gatech.edu Subject: [alsa-devel] [PATCH] emu10k1: correctly handling failed thread creation X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Since kthread_create can be failed, it needs to check whether error occurred and return error code. Signed-off-by: Insu Yun --- sound/pci/emu10k1/emu10k1_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c index 28e2f8b..b9eac15 100644 --- a/sound/pci/emu10k1/emu10k1_main.c +++ b/sound/pci/emu10k1/emu10k1_main.c @@ -1141,6 +1141,12 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu) emu->emu1010.firmware_thread = kthread_create(emu1010_firmware_thread, emu, "emu1010_firmware"); + if (IS_ERR(emu->emu1010.firmware_thread)) { + dev_info(emu->card->dev, + "emu1010: Creating thread failed\n"); + return PTR_ERR(emu->emu1010.firmware_thread); + } + wake_up_process(emu->emu1010.firmware_thread); }