| Message ID | 1454354716-17313-1-git-send-email-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 292d4200a90715ac29f3763df27adb38a243868c |
| Headers | show |
On Mon, Feb 01, 2016 at 01:25:16PM -0600, Pierre-Louis Bossart wrote: > Commit a1068045883ed4a18363a4ebad0c3d55e473b716 added a > dependency on the compress-cpu-dai channel_min field > which was removed earlier by commit > 77095796ae9cbaf315f80611edb5aa569796e339 as part of the > baytrail cleanups. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access or slow internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read. Please also use abbreviated commit IDs, the entire SHA1 is a bit long and does nothing for legibility.
diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index 55c33dc..52ed434 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -528,6 +528,7 @@ static struct snd_soc_dai_driver sst_platform_dai[] = { .ops = &sst_compr_dai_ops, .playback = { .stream_name = "Compress Playback", + .channels_min = 1, }, }, /* BE CPU Dais */
Commit a1068045883ed4a18363a4ebad0c3d55e473b716 added a dependency on the compress-cpu-dai channel_min field which was removed earlier by commit 77095796ae9cbaf315f80611edb5aa569796e339 as part of the baytrail cleanups. The net result was a regression at probe on all Atom platforms with no sound card created. Fix by adding explicit initialization for channel_min to 1 for the compress-cpu-dai. Reported-by: Tobias Mädel <alsa-devel@tbspace.de> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 1 + 1 file changed, 1 insertion(+)