From patchwork Mon Feb 22 03:05:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: PC Liao X-Patchwork-Id: 8371101 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 50DFC9F2F0 for ; Mon, 22 Feb 2016 03:06:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6DF9120390 for ; Mon, 22 Feb 2016 03:06:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 54385200DF for ; Mon, 22 Feb 2016 03:06:13 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0DC0D2657C2; Mon, 22 Feb 2016 04:06:12 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 44BC826068F; Mon, 22 Feb 2016 04:06:04 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 358C52606C3; Mon, 22 Feb 2016 04:06:03 +0100 (CET) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by alsa0.perex.cz (Postfix) with ESMTP id B693126057F for ; Mon, 22 Feb 2016 04:05:55 +0100 (CET) Received: from mtkhts07.mediatek.inc [(172.21.101.69)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 419358819; Mon, 22 Feb 2016 11:05:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkhts07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.266.1; Mon, 22 Feb 2016 11:05:50 +0800 Message-ID: <1456110350.7576.12.camel@mtksdaap41> From: PC Liao To: Mark Brown Date: Mon, 22 Feb 2016 11:05:50 +0800 In-Reply-To: <20160219153744.GP18327@sirena.org.uk> References: <1455849359-14581-1-git-send-email-pc.liao@mediatek.com> <20160219153744.GP18327@sirena.org.uk> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Cc: "alsa-devel@alsa-project.org" , Nicolas Boichat , srv_heupstream , "tiwai@suse.de" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , Koro Chen =?UTF-8?Q?=28=E9=99=B3=E6=80=9D=E7=BF=B0=29?= , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [alsa-devel] [PATCH] ASoC: mediatek: Add machine driver for ALC5650 codec X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mark, On Fri, 2016-02-19 at 23:37 +0800, Mark Brown wrote: > On Fri, Feb 19, 2016 at 10:35:59AM +0800, PC Liao wrote: > > > @@ -3,3 +3,4 @@ obj-$(CONFIG_SND_SOC_MEDIATEK) += mtk-afe-pcm.o > > # Machine support > > obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173-max98090.o > > obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o > > +obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173-rt5650.o > > Why is this not covered by (or coverable by) the existinng RT5650-RT5657 > driver? Thanks for your review. Because they are different boards and have some differences like HW configuration and mixer control, we want to separate machine driver clearly. Otherwise, I think I will upload this change to new version for more clearly. diff --git a/sound/soc/mediatek/Makefile b/sound/soc/mediatek/Makefile index bcdcb06..dcb1440 100644 --- a/sound/soc/mediatek/Makefile +++ b/sound/soc/mediatek/Makefile @@ -2,5 +2,5 @@ obj-$(CONFIG_SND_SOC_MEDIATEK) += mtk-afe-pcm.o # Machine support obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173-max98090.o -obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173-rt5650.o +obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o