diff mbox

[5/5] dt/bindings: sound: new chip added into TAS571x binding

Message ID 1457609100-17164-1-git-send-email-petr@barix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Petr Kulhavy March 10, 2016, 11:25 a.m. UTC
This adds the TAS5721 into the TAS571x binding.

Signed-off-by: Petr Kulhavy <petr@barix.com>
---
 Documentation/devicetree/bindings/sound/tas571x.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Rob Herring (Arm) March 18, 2016, 4:20 p.m. UTC | #1
On Thu, Mar 10, 2016 at 12:25:00PM +0100, Petr Kulhavy wrote:
> This adds the TAS5721 into the TAS571x binding.
> 
> Signed-off-by: Petr Kulhavy <petr@barix.com>
> ---
>  Documentation/devicetree/bindings/sound/tas571x.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas571x.txt b/Documentation/devicetree/bindings/sound/tas571x.txt
> index 0ac31d8..f1aade3 100644
> --- a/Documentation/devicetree/bindings/sound/tas571x.txt
> +++ b/Documentation/devicetree/bindings/sound/tas571x.txt
> @@ -1,4 +1,4 @@
> -Texas Instruments TAS5711/TAS5717/TAS5719 stereo power amplifiers
> +Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 stereo power amplifiers
>  
>  The codec is controlled through an I2C interface.  It also has two other
>  signals that can be wired up to GPIOs: reset (strongly recommended), and
> @@ -6,7 +6,7 @@ powerdown (optional).
>  
>  Required properties:
>  
> -- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719"
> +- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719", "ti,tas5721"

The "or" is in the wrong place. Please reformat to 1 compatible per 
line (unless more than 1 in the DT is valid).

>  - reg: The I2C address of the device
>  - #sound-dai-cells: must be equal to 0
>  
> @@ -25,6 +25,8 @@ Optional properties:
>  - PVDD_B-supply: regulator phandle for the PVDD_B supply (5711)
>  - PVDD_C-supply: regulator phandle for the PVDD_C supply (5711)
>  - PVDD_D-supply: regulator phandle for the PVDD_D supply (5711)
> +- DRVDD-supply: regulator phandle for the DRVDD supply (5721)
> +- PVDD-supply: regulator phandle for the PVDD supply (5721)
>  
>  Example:
>  
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/tas571x.txt b/Documentation/devicetree/bindings/sound/tas571x.txt
index 0ac31d8..f1aade3 100644
--- a/Documentation/devicetree/bindings/sound/tas571x.txt
+++ b/Documentation/devicetree/bindings/sound/tas571x.txt
@@ -1,4 +1,4 @@ 
-Texas Instruments TAS5711/TAS5717/TAS5719 stereo power amplifiers
+Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 stereo power amplifiers
 
 The codec is controlled through an I2C interface.  It also has two other
 signals that can be wired up to GPIOs: reset (strongly recommended), and
@@ -6,7 +6,7 @@  powerdown (optional).
 
 Required properties:
 
-- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719"
+- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719", "ti,tas5721"
 - reg: The I2C address of the device
 - #sound-dai-cells: must be equal to 0
 
@@ -25,6 +25,8 @@  Optional properties:
 - PVDD_B-supply: regulator phandle for the PVDD_B supply (5711)
 - PVDD_C-supply: regulator phandle for the PVDD_C supply (5711)
 - PVDD_D-supply: regulator phandle for the PVDD_D supply (5711)
+- DRVDD-supply: regulator phandle for the DRVDD supply (5721)
+- PVDD-supply: regulator phandle for the PVDD supply (5721)
 
 Example: