| Message ID | 1461809581-7863-1-git-send-email-bardliao@realtek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/28/2016 04:13 AM, Bard Liao wrote: > IN Muxes are not existing on rt5651. > > Signed-off-by: Bard Liao <bardliao@realtek.com> > --- > sound/soc/codecs/rt5651.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c > index 7a61970..b812c06 100644 > --- a/sound/soc/codecs/rt5651.c > +++ b/sound/soc/codecs/rt5651.c > @@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { > RT5651_PWR_IN2_L_BIT, 0, NULL, 0), > SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL, > RT5651_PWR_IN2_R_BIT, 0, NULL, 0), > - /* IN Mux */ > - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux), > - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux), > - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux), > - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux), What is with the rt5651_in*_mux controls, those are unused now and can be removed as well, aren't they?
> > - /* IN Mux */ > > - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, > &rt5651_inl1_mux), > > - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, > &rt5651_inr1_mux), > > - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, > &rt5651_inl2_mux), > > - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, > &rt5651_inr2_mux), > > What is with the rt5651_in*_mux controls, those are unused now and > can be removed as well, aren't they? Thanks for the reminder. I will send v2 soon. > > > ------Please consider the environment before printing this e-mail.
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index 7a61970..b812c06 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { RT5651_PWR_IN2_L_BIT, 0, NULL, 0), SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL, RT5651_PWR_IN2_R_BIT, 0, NULL, 0), - /* IN Mux */ - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux), - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux), - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux), - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux), /* REC Mixer */ SND_SOC_DAPM_MIXER("RECMIXL", RT5651_PWR_MIXER, RT5651_PWR_RM_L_BIT, 0, rt5651_rec_l_mix, ARRAY_SIZE(rt5651_rec_l_mix)),
IN Muxes are not existing on rt5651. Signed-off-by: Bard Liao <bardliao@realtek.com> --- sound/soc/codecs/rt5651.c | 5 ----- 1 file changed, 5 deletions(-)