diff mbox

[02/10] ASoC: Intel: Skylake: Set the pipe state to paused when paused

Message ID 1464958783-19344-3-git-send-email-jeeja.kp@intel.com (mailing list archive)
State Accepted
Commit 353f72aa77581926c0634fffe168f206435a8fc6
Headers show

Commit Message

Jeeja KP June 3, 2016, 12:59 p.m. UTC 
From: Jeeja KP <jeeja.kp@intel.com>

When pipe is stopped/Paused, set the pipe state to paused instead
of created.

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown June 7, 2016, 12:56 p.m. UTC | #1 
On Fri, Jun 03, 2016 at 06:29:35PM +0530, jeeja.kp@intel.com wrote:
> From: Jeeja KP <jeeja.kp@intel.com>
> 
> When pipe is stopped/Paused, set the pipe state to paused instead
> of created.

because...
Jeeja KP June 8, 2016, 9:39 a.m. UTC | #2 
On Tue, Jun 07, 2016 at 01:56:21PM +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 06:29:35PM +0530, jeeja.kp@intel.com wrote:
> > From: Jeeja KP <jeeja.kp@intel.com>
> > 
> > When pipe is stopped/Paused, set the pipe state to paused instead
> > of created.
> 
> because...

after creation of pipe, pipe can be started and stopped mutiple times.
So valid state in this case is PAUSED instead of created.
diff mbox

Patch

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index c682403..07d2a73 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -1125,7 +1125,7 @@  int skl_stop_pipe(struct skl_sst *ctx, struct skl_pipe *pipe)
 		return ret;
 	}
 
-	pipe->state = SKL_PIPE_CREATED;
+	pipe->state = SKL_PIPE_PAUSED;
 
 	return 0;
 }