diff mbox

[RFC,2/6] ASoC: samsung: Add DT bindings documentation for LPASS

Message ID 1465815160-28504-3-git-send-email-s.nawrocki@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics June 13, 2016, 10:52 a.m. UTC 
This patch add documentation of the DT bindings for the Samsung
Exynos SoC Low Power Audio Subsystem.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 .../devicetree/bindings/sound/samsung,exynos5433-lpass.txt        | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt

Comments

Rob Herring (Arm) June 14, 2016, 11:28 p.m. UTC | #1 
On Mon, Jun 13, 2016 at 12:52:36PM +0200, Sylwester Nawrocki wrote:
> This patch add documentation of the DT bindings for the Samsung
> Exynos SoC Low Power Audio Subsystem.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  .../devicetree/bindings/sound/samsung,exynos5433-lpass.txt        | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt

Seems kind of incomplete, but for what's here:

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski June 16, 2016, 11:28 a.m. UTC | #2 
On 06/13/2016 12:52 PM, Sylwester Nawrocki wrote:
> This patch add documentation of the DT bindings for the Samsung
> Exynos SoC Low Power Audio Subsystem.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  .../devicetree/bindings/sound/samsung,exynos5433-lpass.txt        | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics June 16, 2016, 4:13 p.m. UTC | #3 
On 06/15/2016 01:28 AM, Rob Herring wrote:
> On Mon, Jun 13, 2016 at 12:52:36PM +0200, Sylwester Nawrocki wrote:
>> > This patch add documentation of the DT bindings for the Samsung
>> > Exynos SoC Low Power Audio Subsystem.
>> > 
>> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> > ---
>> >  .../devicetree/bindings/sound/samsung,exynos5433-lpass.txt        | 8 ++++++++
>> >  1 file changed, 8 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt
> Seems kind of incomplete, but for what's here:
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks, it's indeed a bit incomplete. Most of the functionality is
already covered by existing bindings of sub-IPs like I2S, DMAC, UART.
I'd expect more detailed binding be specified for newer SoCs and that
would be a different compatible string.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt
new file mode 100644
index 0000000..4beef25
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt
@@ -0,0 +1,8 @@ 
+
+Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
+
+Required properties:
+
+ - compatible : "samsung,exynos5433-lpass"
+ - reg : should contain the LPASS SFR region location and size
+ - samsung,pmu-syscon : the phandle to the Power Management Unit node