| Message ID | 1466136482-21944-1-git-send-email-bardliao@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 874352a763ba2df55093d2651158be40999e9cbe |
| Headers | show |
On Fri, Jun 17, 2016 at 12:08:02PM +0800, Bard Liao wrote: > reg-8a assign the tracking source for each ASRC tracker. The default > value is 0x0000 which means all ASRC trackers will track LRCK1. But > in most case, we wish each ASRC tracker track the corresponding LRCK. > i.e. ASRC1 tracks LRCK1, ASRC2 tracks LRCK2 and so on. So, we rewrite > reg-8a as 0x0123. Shouldn't this be configurable?
> -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Friday, June 17, 2016 7:10 PM > To: Bard Liao > Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; > lars@metafoo.de; Flove; Oder Chiou; Jack Yu > Subject: Re: [PATCH] ASoC: rt5670: patch reg-0x8a > > On Fri, Jun 17, 2016 at 12:08:02PM +0800, Bard Liao wrote: > > > reg-8a assign the tracking source for each ASRC tracker. The default > > value is 0x0000 which means all ASRC trackers will track LRCK1. But in > > most case, we wish each ASRC tracker track the corresponding LRCK. > > i.e. ASRC1 tracks LRCK1, ASRC2 tracks LRCK2 and so on. So, we rewrite > > reg-8a as 0x0123. > > Shouldn't this be configurable? In hardware of view, yes. But, it is not necessary since we can choose which ASRC we want to use. That is selected by another register and is implemented by rt5670_sel_asrc_clk_src function. Without this patch, no matter what ASRC is selected, it will track LRCK1. But with this patch, we can use ASRC2 to track LRCK2. It means we can decide which LRCK is tracked by selecting which ASRC we are using with a fixed value of reg-8a. > > ------Please consider the environment before printing this e-mail.
diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c index 0af5ddb..8ef467f 100644 --- a/sound/soc/codecs/rt5670.c +++ b/sound/soc/codecs/rt5670.c @@ -55,6 +55,7 @@ static const struct reg_sequence init_list[] = { { RT5670_PR_BASE + 0x14, 0x9a8a }, { RT5670_PR_BASE + 0x38, 0x3ba1 }, { RT5670_PR_BASE + 0x3d, 0x3640 }, + { 0x8a, 0x0123 }, }; static const struct reg_default rt5670_reg[] = { @@ -131,7 +132,7 @@ static const struct reg_default rt5670_reg[] = { { 0x87, 0x0000 }, { 0x88, 0x0000 }, { 0x89, 0x0000 }, - { 0x8a, 0x0000 }, + { 0x8a, 0x0123 }, { 0x8b, 0x0000 }, { 0x8c, 0x0003 }, { 0x8d, 0x0000 },
reg-8a assign the tracking source for each ASRC tracker. The default value is 0x0000 which means all ASRC trackers will track LRCK1. But in most case, we wish each ASRC tracker track the corresponding LRCK. i.e. ASRC1 tracks LRCK1, ASRC2 tracks LRCK2 and so on. So, we rewrite reg-8a as 0x0123. Signed-off-by: Bard Liao <bardliao@realtek.com> --- sound/soc/codecs/rt5670.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)