From patchwork Thu Aug 4 10:22:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 9264611 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D8C6460467 for ; Thu, 4 Aug 2016 23:30:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAC7127D85 for ; Thu, 4 Aug 2016 23:30:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEDBA28424; Thu, 4 Aug 2016 23:30:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8420A27D85 for ; Thu, 4 Aug 2016 23:30:42 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 88834266744; Fri, 5 Aug 2016 01:30:40 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 68E5B2668A6; Thu, 4 Aug 2016 19:48:39 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id DF7622668A2; Thu, 4 Aug 2016 19:48:37 +0200 (CEST) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by alsa0.perex.cz (Postfix) with ESMTP id C6CAA266D45 for ; Thu, 4 Aug 2016 12:22:57 +0200 (CEST) Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OBD015CVRI1KH80@mailout4.samsung.com> for alsa-devel@alsa-project.org; Thu, 04 Aug 2016 19:22:49 +0900 (KST) X-AuditID: cbfee61a-f78ff6d000001462-66-57a31779092e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 12.EF.05218.97713A75; Thu, 4 Aug 2016 19:22:49 +0900 (KST) Received: from AMDC1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OBD005JDRHTNY70@mmp1.samsung.com>; Thu, 04 Aug 2016 19:22:49 +0900 (KST) From: Sylwester Nawrocki To: broonie@kernel.org Date: Thu, 04 Aug 2016 12:22:32 +0200 Message-id: <1470306152-15441-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmluLIzCtJLcpLzFFi42I5/e+xgG6l+OJwg+vLTSyuXDzEZNF4v4vR YuOM9awWUx8+YbO49+cDq8WM8/uYLE4nWhx+087qwOGx4XMTm8eaeWsYPTat6mTz6NuyitHj 6Y+9zB5b9n9m9Pi8SS6APYrLJiU1J7MstUjfLoEro/3NBKaC1/wVa5atYG9g3MzbxcjJISFg InHy70pWCFtM4sK99WxdjFwcQgJLGSUu/X3JDuH8YpRYvnsWE0gVm4ChRO/RPkYQWwSo4/ac TmYQm1ngBqNE63QzEFtYwFbi4KdvQJM4OFgEVCWaDnKDhHkF3CSedXexQyyTkzh5bDLrBEbu BYwMqxglUguSC4qT0nMN81LL9YoTc4tL89L1kvNzNzGCg+iZ1A7Gg7vcDzEKcDAq8fBeMF0U LsSaWFZcmXuIUYKDWUmE96nQ4nAh3pTEyqrUovz4otKc1OJDjNIcLErivI//rwsTEkhPLEnN Tk0tSC2CyTJxcEo1MDLGmQjmxazfI/YzWZ311xmtAzU2i47PZVyrN/n6uzeh5ZzPLWXtTsU6 cvaeOnGQJ/SB1fpOsc0p0x/zc7efUTgzbXljwz3z5zUn/h5mf3Vn9ZKoeZMPmE5J80t+q7JD rFJCknftOW6Rbn/b49dCuVXfLW0tr1m7R7hcbdIjrU/tguGTDPWb7ymxFGckGmoxFxUnAgAL jj/xHgIAAA== Cc: Jose.Abreu@synopsys.com, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, Andrew.Jackson@arm.com, rajeevk-dlh.kumar@st.com, Sylwester Nawrocki Subject: [alsa-devel] [PATCH] ASoC: dwc: Drop DMA channel names assignment X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The dw_configure_dai_by_dt() function and further dev->{play,capture} _dma_data.dt data structures seem to be used in this driver only in case of a system using devicetree, thus chan_name assignments have no effect since they will be ignored in dmaengine_pcm_request_chan_of() call and will be substituted with values taken form dmaengine_pcm_dma_channel_names[] table ("tx", "rx"). Also there is no any "TX", "RX" dma-names entries in arch/arm/boot/dts, only lower case "tx", "rx" seem to be used. Lastly, this driver doesn't set SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag when registering a dmaengine PCM to indicate the chan_name should be used. My intention is to eventually remove the struct snd_dmaengine_dai_dma_data chan_name field as there is also a chan_names[] field in struct snd_dmaengine_pcm_config which can be used for same purpose. Signed-off-by: Sylwester Nawrocki --- sound/soc/dwc/designware_i2s.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index dc97f43..2998954 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/designware_i2s.c @@ -577,7 +577,6 @@ static int dw_configure_dai_by_dt(struct dw_i2s_dev *dev, dev->capability |= DWC_I2S_PLAY; dev->play_dma_data.dt.addr = res->start + I2S_TXDMA; dev->play_dma_data.dt.addr_width = bus_widths[idx]; - dev->play_dma_data.dt.chan_name = "TX"; dev->play_dma_data.dt.fifo_size = fifo_depth * (fifo_width[idx2]) >> 8; dev->play_dma_data.dt.maxburst = 16; @@ -588,7 +587,6 @@ static int dw_configure_dai_by_dt(struct dw_i2s_dev *dev, dev->capability |= DWC_I2S_RECORD; dev->capture_dma_data.dt.addr = res->start + I2S_RXDMA; dev->capture_dma_data.dt.addr_width = bus_widths[idx]; - dev->capture_dma_data.dt.chan_name = "RX"; dev->capture_dma_data.dt.fifo_size = fifo_depth * (fifo_width[idx2] >> 8); dev->capture_dma_data.dt.maxburst = 16;